From: Jakub Narebski <jnareb@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Elijah Newren" <newren@gmail.com>,
git@vger.kernel.org
Subject: Re: [RFC PATCHv2 09/16] t4026 (color): add missing &&
Date: Sat, 25 Sep 2010 00:56:24 -0700 (PDT) [thread overview]
Message-ID: <m3d3s2gsub.fsf@localhost.localdomain> (raw)
In-Reply-To: <20100925040227.GA21416@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> On Fri, Sep 24, 2010 at 10:55:08PM +0000, Ævar Arnfjörð Bjarmason wrote:
>
> > On Fri, Sep 24, 2010 at 22:22, Elijah Newren <newren@gmail.com> wrote:
> > > FIXME: Is it intended that this git config --unset fail? I had to add a
> > > test_might_fail as well.
> >
> > Presumably this is to work around the user having diff.color in his
> > config or something? Should we be leaking like that?
>
> No, it was to clean up from previous tests, which set diff.color.new, to
> make sure we had a clean environment. So it should have been might_fail
> (but it predated might_fail, which is why it wasn't).
Shouldn't modern test script use 'test_when_finished <script>' for
cleanup instead?
> But look at 8b124135, which came later. It changed the color() and
> invalid_color() helpers to no longer use diff.color.new, so that cleanup
> is now obsolete. So that line can simply be removed now.
Well, there is that.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-09-25 7:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 22:22 [RFC PATCHv2 00/16] Add missing &&'s in the testsuite Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 01/16] t3020 (ls-files-error-unmatch): remove stray '1' from end of file Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 02/16] t4017 (diff-retval): replace manual exit code check with test_expect_code Elijah Newren
2010-09-24 22:49 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 03/16] t1001 (read-tree-m-2way): add missing && Elijah Newren
2010-09-24 22:50 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 04/16] t1002 (read-tree-m-u-2way): " Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 05/16] t4002 (diff-basic): use test_might_fail for commands that might fail Elijah Newren
2010-09-24 22:52 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 06/16] t4202 (log): Replace '<git-command> || :' with test_might_fail Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 07/16] t3600 (rm): add lots of missing && Elijah Newren
2010-09-24 22:58 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 08/16] t4019 (diff-wserror): " Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 09/16] t4026 (color): add " Elijah Newren
2010-09-24 22:55 ` Ævar Arnfjörð Bjarmason
2010-09-25 4:02 ` Jeff King
2010-09-25 7:56 ` Jakub Narebski [this message]
2010-09-24 22:22 ` [RFC PATCHv2 10/16] t5602 (clone-remote-exec): " Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 11/16] t6016 (rev-list-graph-simplify-history): " Elijah Newren
2010-09-24 23:00 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 12/16] t6050 (replace): " Elijah Newren
2010-09-24 23:04 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 13/16] t7001 (mv): " Elijah Newren
2010-09-24 23:00 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 14/16] t7601 (merge-pull-config): " Elijah Newren
2010-09-24 22:22 ` [RFC PATCHv2 15/16] t7800 (difftool): " Elijah Newren
2010-09-24 23:02 ` Ævar Arnfjörð Bjarmason
2010-09-24 22:22 ` [RFC PATCHv2 16/16] Add missing &&'s throughout the testsuite Elijah Newren
2010-09-24 23:18 ` Ævar Arnfjörð Bjarmason
2010-09-25 16:50 ` Elijah Newren
2010-09-25 17:05 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3s2gsub.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.