From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39661 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OLWGs-00020s-CS
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 02:57:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OLWGq-0000uj-Qn
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 02:57:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38201)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1OLWGq-0000u4-JT
	for qemu-devel@nongnu.org; Mon, 07 Jun 2010 02:57:16 -0400
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o576vEEF026100
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 7 Jun 2010 02:57:14 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] monitor: allow device to be ejected if no
	disk is inserted
References: <20100601221219.GB13961@blackpad.lan.raisama.net>
	<20100604150120.752571e8@redhat.com>
Date: Mon, 07 Jun 2010 08:57:12 +0200
In-Reply-To: <20100604150120.752571e8@redhat.com> (Luiz Capitulino's message
	of "Fri, 4 Jun 2010 15:01:20 -0300")
Message-ID: <m3d3w349fb.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Tue, 1 Jun 2010 19:12:19 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
>
>> I have no clue why the code had the is_inserted() check, as it doesn't matter
>> if there is a disk present at the host drive, when the user wants the virtual
>> device to be disconnected from the host device.
>
>  Makes sense, although I have no idea if doing a bdrv_close() on a bs which
> doesn't have an image inserted has any side effect.

Should be a no-op.

>  Basic testing works as expected, though.
>
>  Anyway, I think this should go through the block queue.

Makes sense.