From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45202 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFY5B-00040I-QM for qemu-devel@nongnu.org; Fri, 21 May 2010 15:40:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OFY5A-0006oJ-8n for qemu-devel@nongnu.org; Fri, 21 May 2010 15:40:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31536) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OFY59-0006o8-RB for qemu-devel@nongnu.org; Fri, 21 May 2010 15:40:32 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH v2] Release usb devices on shutdown and usb_del command References: <4BF6D4B3.3050606@cisco.com> Date: Fri, 21 May 2010 21:40:26 +0200 In-Reply-To: <4BF6D4B3.3050606@cisco.com> (David S. Ahern's message of "Fri, 21 May 2010 12:45:07 -0600") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "David S. Ahern" Cc: qemu-devel "David S. Ahern" writes: >> On 05/21/2010 1:33 AM, Markus Armbruster wrote: >> Note: usbdevice_init() is not for general initialization, just for >> dealing with the legacy -usbdevice command line. > > Perhaps the comment before usbdevice_create is misleading or has some > conversion not completed? Right now even devices entered through the > monitor go through usbdevice_create -- which is the only place the > usbdevice_init() hook is invoked. ... just for dealing with the -usbdevice command line and monitor command usb_add (both legacy). Check out docs/qdev-device-use.txt for the current way to add devices. The monitor equivalent to -device is device_add.