From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKqmN-0004ux-Mn for qemu-devel@nongnu.org; Wed, 16 Dec 2009 05:06:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKqmI-0004sZ-EY for qemu-devel@nongnu.org; Wed, 16 Dec 2009 05:06:46 -0500 Received: from [199.232.76.173] (port=42908 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKqmI-0004sW-Ag for qemu-devel@nongnu.org; Wed, 16 Dec 2009 05:06:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45584) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NKqmH-0004Q6-Qt for qemu-devel@nongnu.org; Wed, 16 Dec 2009 05:06:42 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] Re: [PATCH] Fix TEXTREL in user targets when compiled with --enable-user-pie References: <1260839404-28622-1-git-send-email-kirill@shutemov.name> Date: Wed, 16 Dec 2009 11:06:39 +0100 In-Reply-To: (Kirill A. Shutemov's message of "Wed, 16 Dec 2009 11:25:19 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Kirill A. Shutemov" Cc: Paolo Bonzini , qemu-devel@nongnu.org "Kirill A. Shutemov" writes: > On Wed, Dec 16, 2009 at 11:15 AM, Paolo Bonzini wro= te: >> On 12/16/2009 09:45 AM, Kirill A. Shutemov wrote: >>>>>> >>>>>> >>> =C2=A0-VPATH=3D$(SRC_PATH) >>>>>> >>> =C2=A0+vpath %.c $(SRC_PATH) >>>> >>>> > >>>> > =C2=A0This change is needed? >>> >>> Yes. We dont want to take %.o from $(SRC_PATH) since they built without >>> -fpie. >> >> I think that's fine, it's kind of the purpose of vpath to only look for >> sources in the vpath; so it's safer to use "vpath" than "VPATH". =C2=A0T= hat said, >> I'd change it to >> >> vpath %.c %.h $(SRC_PATH) > > We don't have make-targets which require %.h in Makefile.user, so it's no= ise. It may be noise now, but it the first guy who adds one there will be grateful for it, and... >> and I'd do so uniformly in all the directories that currently use VPATH. ... doing it uniformly makes more sense.