From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MWFV7-0005pD-UM
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 16:11:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MWFV2-0005mB-CD
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 16:11:48 -0400
Received: from [199.232.76.173] (port=54336 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MWFV2-0005m8-4J
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 16:11:44 -0400
Received: from mx2.redhat.com ([66.187.237.31]:59353)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <quintela@redhat.com>) id 1MWFV1-0007US-Nu
	for qemu-devel@nongnu.org; Wed, 29 Jul 2009 16:11:44 -0400
In-Reply-To: <4A70ABA4.5090105@codemonkey.ws> (Anthony Liguori's message of
	"Wed\, 29 Jul 2009 15\:05\:56 -0500")
References: <20090729120719.GN30449@redhat.com>
	<20090729135057.GY30449@redhat.com>
	<5b31733c0907290735u5dd86d86i293f34df4ce09d10@mail.gmail.com>
	<4A70A400.2070703@codemonkey.ws> <m3vdlb2s06.fsf@neno.mitica>
	<4A70ABA4.5090105@codemonkey.ws>
From: Juan Quintela <quintela@redhat.com>
Date: Wed, 29 Jul 2009 22:09:42 +0200
Message-ID: <m3d47j2qux.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH v2] make windows notice media change
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Filip Navara <filip.navara@gmail.com>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>

Anthony Liguori <anthony@codemonkey.ws> wrote:
> Juan Quintela wrote:
>> You didn't lost anything from the old version, it already have the bug.
>> Value that you give it: zero.  If it was in the middle of the operation,
>> it will give the same bug that when it was in the older host,
>
> Right, which is the root of the problem.  You migrate to a new version
> of QEMU to fix bugs.  If we don't fix bugs because we migrated from an
> old version, we end up in a strange situation resulting in strange bug
> reports.

In this very case, bug is fixed from now on.  It can only happens once,
at maximum, I consider it a net gain.  Bug we are fixing here is that
windows don't detect correctly that we have changed the media, in the
old version, it can happens depending on ...., if you migrate to the new
version, you can have that problem a maximum of _one_ time, after that,
the value of the variable will always be right.

Later, Juan.