From: Jakub Narebski <jnareb@gmail.com>
To: "Edward Z. Yang" <edwardzyang@thewritingpot.com>
Cc: git@vger.kernel.org
Subject: Re: gitweb and unicode special characters
Date: Sat, 13 Dec 2008 14:08:29 -0800 (PST) [thread overview]
Message-ID: <m3d4fvg23p.fsf@localhost.localdomain> (raw)
In-Reply-To: <ghv8rf$47v$1@ger.gmane.org>
"Edward Z. Yang" <edwardzyang@thewritingpot.com> writes:
> Jakub Narebski wrote:
> > Sidenote: There is probably one exception we want to add, namely not
> > escape '\r' at the end of line, to be able to deal better with DOS
> > line endings (\r\n).
>
> I'm sorry, but I have to disagree. I find being able to see \r
> line-endings in the pretty-printed format is exceedingly useful for
> figuring out if a file has been checked in with the wrong line-endings.
> The number of files that must have \r line endings are vanishingly small
> (BAT files are perhaps the one example I can think of right now).
Well, it is a bit annoying if you have checked file with wrong line
endings, and just noticed this... I was thinking about adding '(DOS)'
or something indicator at the bottom of 'blob' and 'blame' views, but
I guess I can live with '\r'...
In short: I agree, that was not a good idea.
--
Jakub Narebski
Poland
ShadeHawk on #git
prev parent reply other threads:[~2008-12-13 22:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 18:33 gitweb and unicode special characters Praveen A
2008-12-12 19:37 ` Jakub Narebski
2008-12-12 22:09 ` Jakub Narebski
2008-12-13 0:55 ` Praveen A
2008-12-13 1:31 ` Jakub Narebski
2008-12-13 3:06 ` Edward Z. Yang
2008-12-13 22:08 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d4fvg23p.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=edwardzyang@thewritingpot.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.