Re: [PATCH 4/5] lib: avoid double free in loopdev.c

[yumkam@gmail.com (Yuriy M. Kaminskiy)]

Sami Kerola <kerolasa@iki.fi> writes:

> Found with scan-build.
>
> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
> ---
>  lib/loopdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/loopdev.c b/lib/loopdev.c
> index 9ae61da..ca5d2f4 100644
> --- a/lib/loopdev.c
> +++ b/lib/loopdev.c
> @@ -460,6 +460,7 @@ static int loop_scandir(const char *dirname, int **ary, int hasprefix)
>  			tmp = realloc(*ary, arylen * sizeof(int));
>  			if (!tmp) {
>  				free(*ary);
> +				ary = NULL;

This cannot have any effect. Probably you wanted
                                *ary = NULL;
                                
>  				closedir(dir);
>  				return -1;
>  			}