From: khalasa@piap.pl (Krzysztof Hałasa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v2 2/2] ixp4xx_eth: Setup coherent_dma_mask
Date: Tue, 18 Mar 2014 08:43:09 +0100 [thread overview]
Message-ID: <m3eh20j6k2.fsf@t19.piap.pl> (raw)
In-Reply-To: <20140317144244.6d2e09f9@marrow.netinsight.se> ("Simon Kågström"'s message of "Mon, 17 Mar 2014 14:42:44 +0100")
Simon K?gstr?m <simon.kagstrom@netinsight.net> writes:
> +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
> @@ -1426,6 +1426,10 @@ static int eth_init_one(struct platform_device *pdev)
> port->netdev = dev;
> port->id = pdev->id;
>
> + err = dma_set_coherent_mask(&dev->dev, DMA_BIT_MASK(32));
> + if (err < 0)
> + goto err_free;
> +
Yeah. One could also set both masks with the new single call. The driver
uses both streaming and coherent mapping.
--
Krzysztof Halasa
Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
next prev parent reply other threads:[~2014-03-18 7:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 13:40 [PATCH RESEND v2 0/2]: ixp4xx: Fix 3.7 regression for IXP4xx ethernet driver Simon Kågström
2014-03-17 13:42 ` [PATCH RESEND v2 1/2] ARM: ixp4xx: Make dma_set_coherent_mask common, correct implementation Simon Kågström
2014-03-18 14:58 ` Arnd Bergmann
2014-03-20 8:03 ` Simon Kågström
2014-03-20 9:34 ` Krzysztof Hałasa
2014-03-20 11:02 ` Arnd Bergmann
2014-03-20 11:05 ` Simon Kågström
2014-03-17 13:42 ` [PATCH RESEND v2 2/2] ixp4xx_eth: Setup coherent_dma_mask Simon Kågström
2014-03-18 7:43 ` Krzysztof Hałasa [this message]
2014-03-20 11:10 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3eh20j6k2.fsf@t19.piap.pl \
--to=khalasa@piap.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.