From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58301 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P0abH-0005cQ-WE
	for qemu-devel@nongnu.org; Tue, 28 Sep 2010 09:52:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1P0abG-0002gj-Cd
	for qemu-devel@nongnu.org; Tue, 28 Sep 2010 09:52:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59287)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <armbru@redhat.com>) id 1P0abG-0002ge-4f
	for qemu-devel@nongnu.org; Tue, 28 Sep 2010 09:52:06 -0400
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] qdev: Add a description field for qdev
	properties for documentation
References: <cover.1284553514.git.amit.shah@redhat.com>
	<cover.1284553514.git.amit.shah@redhat.com>
	<b8f2ad691ff783d815c38918f223646b6518b522.1284553514.git.amit.shah@redhat.com>
Date: Tue, 28 Sep 2010 15:52:02 +0200
In-Reply-To: <b8f2ad691ff783d815c38918f223646b6518b522.1284553514.git.amit.shah@redhat.com>
	(Amit Shah's message of "Wed, 15 Sep 2010 18:06:49 +0530")
Message-ID: <m3eiceascd.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>

Amit Shah <amit.shah@redhat.com> writes:

> Add a 'description' along with each qdev property to document the input
> each qdev property takes.
[...]
> diff --git a/hw/qdev.c b/hw/qdev.c
> index 35858cb..b415025 100644
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -188,7 +188,8 @@ int qdev_device_help(QemuOpts *opts)
>          if (!prop->info->parse) {
>              continue;           /* no way to set it, don't show */
>          }
> -        error_printf("%s.%s=%s\n", info->name, prop->name, prop->info->name);
> +        error_printf("%s.%s=%s, %s\n", info->name, prop->name,
> +                     prop->info->name, prop->desc ?: "");
>      }
>      return 1;
>  }

This is the only patch hunk that isn't about defining or initializing
the new member desc, isn't it?

[...]