From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51285 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOWPa-00069k-Oz
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:42:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1OOWPR-0000VX-D2
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:42:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54741)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <quintela@redhat.com>) id 1OOWPR-0000VQ-3R
	for qemu-devel@nongnu.org; Tue, 15 Jun 2010 09:42:33 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5FDgWkM005277
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 15 Jun 2010 09:42:32 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <4C176DD1.2010605@redhat.com> (Jes Sorensen's message of "Tue, 15
	Jun 2010 14:10:57 +0200")
References: <1276599879-22749-1-git-send-email-Jes.Sorensen@redhat.com>
	<4C176C3D.5020103@redhat.com> <4C176DD1.2010605@redhat.com>
Date: Tue, 15 Jun 2010 15:42:29 +0200
Message-ID: <m3eig876pm.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 0/7] Fix building qemu-kvm for non KVM
	target
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org

Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
> On 06/15/10 14:04, Avi Kivity wrote:
>> It's the other way round.  Upstream keeps moving stuff out of
>> Makefile.target, and I move them back during merges, because the only
>> thing I can think of during a merge is "how quickly can I complete this
>> merge".
>> 
>> Thanks for tackling this.
>
> I see. I found at least some of the cases I was tackling was because
> things had moved from .objs to .target because of the TARGET_I386
> checks. Trying to use TARGET_I386 in a file that is listed in
> Makefile.objs causes nasty warnings.
>
> I would very much like it if we can be more strict not allowing such
> changes without a very strong reason in the future :)
>
> Part of the problem is of course that there are no easy ways to check
> for the presence of say HPET since we don't have CONFIG_HPET so
> TARGET_I386 becomes the easy way :(

On my hpet removal patches, the important bit was that I enabled
#define CONFIG_HPET 1

in C land, that makes it easy to do this kind of tests.  As it is today,
it is very difficult to test for a feature, as we only have TARGET_*
defines.

Instead of CONFIG_HPET, we have TARGET_I386.

Later, Juan.