From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753959Ab1LLTkB (ORCPT ); Mon, 12 Dec 2011 14:40:01 -0500 Received: from mga02.intel.com ([134.134.136.20]:50711 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753227Ab1LLTkA (ORCPT ); Mon, 12 Dec 2011 14:40:00 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,351,1309762800"; d="scan'208";a="86397699" From: bruce robertson To: Cc: , , , , , Subject: Re: [PATCH v3 3/5] max17042: Add support for signalling change in SOC References: <1323715173-26974-1-git-send-email-dirk.brandewie@gmail.com> <1323715173-26974-4-git-send-email-dirk.brandewie@gmail.com> Date: Mon, 12 Dec 2011 11:39:59 -0800 In-Reply-To: <1323715173-26974-4-git-send-email-dirk.brandewie@gmail.com> (dirk brandewie's message of "Mon, 12 Dec 2011 10:39:31 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org writes: > From: Dirk Brandewie > > If platform has the alert pin attached to an interrupt source have the > driver signal a change in the SOC every 1 percent. > > Signed-off-by: Dirk Brandewie > --- > drivers/power/max17042_battery.c | 54 ++++++++++++++++++++++++++++++++++++++ > 1 files changed, 54 insertions(+), 0 deletions(-) > > diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c > index f2ca950..ac17d36 100644 > --- a/drivers/power/max17042_battery.c > +++ b/drivers/power/max17042_battery.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -43,6 +44,11 @@ > #define STATUS_SMX_BIT (1 << 14) > #define STATUS_BR_BIT (1 << 15) > > +/* Interrupt mask bits */ > +#define CONFIG_ALRT_BIT_ENBL (1 << 2) > +#define STATUS_INTR_SOC_BIT (1 << 14) > +#define STATUS_INTR_LOW_SOC_BIT (1 << 10) > + > #define VFSOC0_LOCK 0x0000 > #define VFSOC0_UNLOCK 0x0080 > #define MODEL_UNLOCK1 0X0059 > @@ -522,6 +528,40 @@ static int max17042_init_chip(struct max17042_chip *chip) > return 0; > } > > +static void max17042_set_soc_threshold(struct max17042_chip *chip, u16 off) > +{ > + u16 soc, soc_tr; > + > + /* program interrupt thesholds such that we should > + * get interrupt for every 'off' perc change in the soc > + */ > + soc = max17042_read_reg(chip->client, MAX17042_RepSOC) >> 8; > + soc_tr = (soc + off) << 8; > + soc_tr |= (soc - off); > + max17042_write_reg(chip->client, MAX17042_SALRT_Th, soc_tr); > +} > + > +static irqreturn_t max17042_intr_handler(int id, void *dev) > +{ > + return IRQ_WAKE_THREAD; > +} > + > +static irqreturn_t max17042_thread_handler(int id, void *dev) > +{ > + struct max17042_chip *chip = dev; > + u16 val; > + > + val = max17042_read_reg(chip->client, MAX17042_STATUS); > + if ((val & STATUS_INTR_SOC_BIT) || > + (val & STATUS_INTR_LOW_SOC_BIT)) { > + printk(KERN_ERR "SOC threshold INTR\n"); Why error? > + dev_info(&chip->client->dev, "SOC threshold INTR\n"); > + max17042_set_soc_threshold(chip, 1); > + } > + > + power_supply_changed(&chip->battery); Didn't nothing change if neither INTR_SOC nor INTR_LOW_SOC aren't set? I think the notification and IRQ_HANDLED should be gated by finding an IRQ bit else return IRQ_NONE. Now that might deserve a dev_err(). > + return IRQ_HANDLED; > +} > > static void max17042_init_worker(struct work_struct *work) > { > @@ -584,6 +624,20 @@ static int __devinit max17042_probe(struct i2c_client *client, > MAX17042_DEFAULT_SNS_RESISTOR; > } > > + if (client->irq) { > + ret = request_threaded_irq(client->irq, max17042_intr_handler, > + max17042_thread_handler, > + 0, chip->battery.name, chip); > + if (!ret) { > + reg = max17042_read_reg(client, MAX17042_CONFIG); > + reg |= CONFIG_ALRT_BIT_ENBL; > + max17042_write_reg(client, MAX17042_CONFIG, reg); > + max17042_set_soc_threshold(chip, 1); > + } else > + dev_err(&client->dev, "%s(): cannot get IRQ\n", > + __func__); > + } > + > reg = max17042_read_reg(chip->client, MAX17042_STATUS); > > if (reg & STATUS_POR_BIT) {