From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933599AbXDGAQz (ORCPT ); Fri, 6 Apr 2007 20:16:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933605AbXDGAQz (ORCPT ); Fri, 6 Apr 2007 20:16:55 -0400 Received: from khc.piap.pl ([195.187.100.11]:46040 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933611AbXDGAQx (ORCPT ); Fri, 6 Apr 2007 20:16:53 -0400 To: Jan Engelhardt Cc: David Brownell , Stefan Richter , Randy Dunlap , Tony Lindgren , linux-kernel@vger.kernel.org Subject: Re: coding style for long conditions (WAS: Re: [PATCH 25/90] ... blinky leds!!) References: <11757099691323-git-send-email-tony@atomide.com> <200704061029.55710.david-b@pacbell.net> <46169968.2050006@s5r6.in-berlin.de> <200704061405.50169.david-b@pacbell.net> From: Krzysztof Halasa Date: Sat, 07 Apr 2007 02:16:51 +0200 In-Reply-To: (Jan Engelhardt's message of "Fri, 6 Apr 2007 23:53:45 +0200 (MEST)") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jan Engelhardt writes: > Tabs should be used for indent, not padding. People wanting to use > different-sized tabs can change settings in their editor, i.e. > to make a tab 12 instead of 8. Or 6. Or whatever. If tabs only ever > appear at the front, this works, it breaks when tabs are used to line > up foo->bar=1; foo->boom=17; statements. Precisely. If someone really likes if (a && b) or if ( a && b ) then let be it (in his/her code), but please don't fight if (a && b) Just make sure only tabs are used for indent, i.e., the last is: \t*if (a && \t*\s\s\s\sb) another example: \t*if (condition1 && (a + \t* b)) ^^^^^^^^^^^^^^^^^^^ <<< spaces, not tabs I think the current CodingStyle is clear enough but improvements there aren't prohibited. -- Krzysztof Halasa