From: Andi Kleen <ak@muc.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, JBeulich@novell.com
Subject: Re: sys_ioctl export consolidation
Date: Fri, 07 May 2004 08:17:03 +0200 [thread overview]
Message-ID: <m3fzac69sw.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <1SSw7-35a-11@gated-at.bofh.it> (Christoph Hellwig's message of "Thu, 06 May 2004 17:00:15 +0200")
Christoph Hellwig <hch@infradead.org> writes:
> Should ioctl32 handlers in drivers really call sys_ioctl? Calling sys_ioctl
> makes sense for ioctls that are supported by a broad range of drivers, but
> in that case the ioctl32 translation should be in the core compat code.
>
> Drivers using register_ioctl32_conversion should rather call their own
> ioctl handlers directly if you ask me.
I think it is better to call sys_ioctl always from the wrappers and
only convert the arguments. This way you are guaranteed to not get
subtle differences in behaviour. This gives a clear layering. Otherwise
driver writers have to do this ad-hoc and only chaos can evolve from
that.
In addition this is how all the current ioctl handlers work, no need
to be different.
-Andi
next parent reply other threads:[~2004-05-07 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1SPff-rH-29@gated-at.bofh.it>
[not found] ` <1SSw7-35a-11@gated-at.bofh.it>
2004-05-07 6:17 ` Andi Kleen [this message]
2004-05-06 15:49 sys_ioctl export consolidation Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2004-05-06 11:23 Jan Beulich
2004-05-06 14:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fzac69sw.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=JBeulich@novell.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.