From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QcXy1-0002ex-L8
	for qemu-devel@nongnu.org; Fri, 01 Jul 2011 03:16:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QcXxz-0006SS-M0
	for qemu-devel@nongnu.org; Fri, 01 Jul 2011 03:16:45 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58930)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QcXxz-0006S1-0D
	for qemu-devel@nongnu.org; Fri, 01 Jul 2011 03:16:43 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p617GeMb027337
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 1 Jul 2011 03:16:40 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1309458783-12661-1-git-send-email-lcapitulino@redhat.com>
	<1309458783-12661-2-git-send-email-lcapitulino@redhat.com>
Date: Fri, 01 Jul 2011 09:16:38 +0200
In-Reply-To: <1309458783-12661-2-git-send-email-lcapitulino@redhat.com> (Luiz
	Capitulino's message of "Thu, 30 Jun 2011 15:33:01 -0300")
Message-ID: <m3hb7679nt.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> Some constructions in that function have broken indentation. Fix them.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  blockdev.c |   52 ++++++++++++++++++++++++++--------------------------
>  1 files changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index 7d579d6..27bf68a 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -272,23 +272,23 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
>          if (type == IF_COUNT) {
>              error_report("unsupported bus type '%s'", buf);
>              return NULL;
> -	}
> +	    }

Old indentation is correct, apart from tabs.

New indentation is incorrect, and fails to remove tabs.

        if (type == IF_COUNT) {
            error_report("unsupported bus type '%s'", buf);
            return NULL;
	    }
^^^^^^^^    ^
tab here    incorrect indentation

Check your editor settings.

I don't see "broken" indentation anywhere in this function.  A few lines
are off: indented 3 instead of 4.  If we want to fix such things, I'd
prefer it done globally.