From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46199 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PsAoD-0007F3-8K
	for qemu-devel@nongnu.org; Wed, 23 Feb 2011 04:14:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PsAoB-00008m-Na
	for qemu-devel@nongnu.org; Wed, 23 Feb 2011 04:14:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12252)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PsAoB-00008Y-Eg
	for qemu-devel@nongnu.org; Wed, 23 Feb 2011 04:14:55 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <AANLkTing-zdSe13VKoayqf60aYbhFOAcxnvc1cUrwA8i@mail.gmail.com>
	(Yoshiaki Tamura's message of "Wed, 23 Feb 2011 17:07:09 +0900")
References: <cover.1298421307.git.quintela@redhat.com>
	<cbcfdae0dd8935f17b24fb97916d2db7a2d016f9.1298421307.git.quintela@redhat.com>
	<AANLkTing-zdSe13VKoayqf60aYbhFOAcxnvc1cUrwA8i@mail.gmail.com>
Date: Wed, 23 Feb 2011 10:13:17 +0100
Message-ID: <m3hbbv866q.fsf@trasno.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 03/22] migration: Fold MigrationState into
	FdMigrationState
Reply-To: quintela@redhat.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: qemu-devel@nongnu.org

Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp> wrote:
> 2011/2/23 Juan Quintela <quintela@redhat.com>:

>> =C2=A0struct FdMigrationState
>> =C2=A0{
>> - =C2=A0 =C2=A0MigrationState mig_state;
>> =C2=A0 =C2=A0 int64_t bandwidth_limit;
>> =C2=A0 =C2=A0 QEMUFile *file;
>> =C2=A0 =C2=A0 int fd;
>> @@ -48,7 +35,12 @@ struct FdMigrationState
>> =C2=A0 =C2=A0 int (*get_error)(struct FdMigrationState*);
>> =C2=A0 =C2=A0 int (*close)(struct FdMigrationState*);
>> =C2=A0 =C2=A0 int (*write)(struct FdMigrationState*, const void *, size_=
t);
>> + =C2=A0 =C2=A0void (*cancel)(FdMigrationState *s);
>> + =C2=A0 =C2=A0int (*get_status)(FdMigrationState *s);
>> + =C2=A0 =C2=A0void (*release)(FdMigrationState *s);
>> =C2=A0 =C2=A0 void *opaque;
>> + =C2=A0 =C2=A0int blk;
>> + =C2=A0 =C2=A0int shared;
>> =C2=A0};
>
> Although I don't have objections for folding MigrationState into
> FdMigrationState, it would be good to ask why the original author
> split it intentionally.

I asked, Anthony answer was that it is a "historical" artifact.

Later, Juan.