All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Severin Gehwolf <jerboaa@gmail.com>
Cc: git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [Bug] Gitweb corrupting files?
Date: Wed, 12 Jan 2011 10:05:45 -0800 (PST)	[thread overview]
Message-ID: <m3hbdeatgn.fsf@localhost.localdomain> (raw)
In-Reply-To: <AANLkTim84sSWr=WRgjiY=Y3Mq7Tgojv9CpLrNjQMJfHR@mail.gmail.com>

Severin Gehwolf <jerboaa@gmail.com> writes:

> It appears that Gitweb corrupts files when it is being used for
> creating compressed tarballs of sources.

E.g. http://egit.eclipse.org/w/?p=egit.git;a=snapshot;h=6b528445c3e543688b990e0a631c5f0238b02741;sf=tbz2
error in egit/org.eclipse.egit.ui/src/org/eclipse/egit/ui/internal/dialogs/BranchSelectionDialog.java

> A more precise description of the behaviour I'm experiencing is here:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=317882

Couldn't you post summary of the above here?
 
> Unfortunately I have no knowledge about the version in use at eclipse.org.

It's git and gitweb version 1.6.4.4.


>From original bugreport:

   And it built fine. Then, I tried checking out sources from command line using
   the git client:

   git clone git://egit.eclipse.org/egit.git egit
   cd egit

   git checkout 6b528445c3e543688b990e0a631c5f0238b02741
   cd ..
   tar -cjf egit_test.tar.bz2 egit

This should be

$ git archive --format=tar 6b528445c3e543688b990e0a631c5f0238b02741 |
  bzip2 > egit_test.tar.bz2

   just to make sure that it isn't a problem of how tarballs are created when
   using the above URL. It seems the file in the repository is corrupted (although
   I'm not entirely convinced).      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Git version 1.6.4.4 is long since fixing bug with not using ':raw'
(binary) output layer with binary files.  Also I don't see how it
could have corrupted only 2 files, without making [compressed] archive
un-compressable (invalid).

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  parent reply	other threads:[~2011-01-12 18:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12 16:05 [Bug] Gitweb corrupting files? Severin Gehwolf
2011-01-12 17:08 ` J.H.
2011-01-12 18:05 ` Jakub Narebski [this message]
2011-01-15 15:39   ` [Not a] " Severin Gehwolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3hbdeatgn.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jerboaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.