From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Franck Bui-Huu <vagabon.xyz@gmail.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Francis Moreau <francis.moro@gmail.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-perf-users@vger.kernel.org,
2nddept-manager@sdl.hitachi.co.jp
Subject: [PATCH 1/2] perf-probe: do use the kernel image path given by 'k' option
Date: Fri, 10 Dec 2010 14:06:03 +0100 [thread overview]
Message-ID: <m3hbelydz8.fsf_-_@gmail.com> (raw)
In-Reply-To: <m3lj3xye9a.fsf@gmail.com> (Franck Bui-Huu's message of "Fri, 10 Dec 2010 14:00:01 +0100")
From: Franck Bui-Huu <fbuihuu@gmail.com>
Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
---
tools/perf/builtin-probe.c | 5 +++++
tools/perf/util/probe-event.c | 15 ++++++++++++---
tools/perf/util/symbol.c | 4 ++--
tools/perf/util/symbol.h | 2 ++
4 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
index 2e000c0..add163c 100644
--- a/tools/perf/builtin-probe.c
+++ b/tools/perf/builtin-probe.c
@@ -249,6 +249,11 @@ int cmd_probe(int argc, const char **argv, const char *prefix __used)
!params.show_lines))
usage_with_options(probe_usage, options);
+ /*
+ * Only consider the user's kernel image path if given.
+ */
+ symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
+
if (params.list_events) {
if (params.mod_events) {
pr_err(" Error: Don't use --list with --add/--del.\n");
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 694f04b..99f9933 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -114,6 +114,8 @@ static struct symbol *__find_kernel_function_by_name(const char *name,
const char *kernel_get_module_path(const char *module)
{
struct dso *dso;
+ struct map *map;
+ const char *vmlinux_name;
if (module) {
list_for_each_entry(dso, &machine.kernel_dsos, node) {
@@ -123,10 +125,17 @@ const char *kernel_get_module_path(const char *module)
}
pr_debug("Failed to find module %s.\n", module);
return NULL;
+ }
+
+ map = machine.vmlinux_maps[MAP__FUNCTION];
+ dso = map->dso;
+
+ vmlinux_name = symbol_conf.vmlinux_name;
+ if (vmlinux_name) {
+ if (dso__load_vmlinux(dso, map, vmlinux_name, NULL) <= 0)
+ return NULL;
} else {
- dso = machine.vmlinux_maps[MAP__FUNCTION]->dso;
- if (dso__load_vmlinux_path(dso,
- machine.vmlinux_maps[MAP__FUNCTION], NULL) < 0) {
+ if (dso__load_vmlinux_path(dso, map, NULL) < 0) {
pr_debug("Failed to load kernel map.\n");
return NULL;
}
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index a3a0c43..4e42e0d 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1780,8 +1780,8 @@ out_failure:
return -1;
}
-static int dso__load_vmlinux(struct dso *self, struct map *map,
- const char *vmlinux, symbol_filter_t filter)
+int dso__load_vmlinux(struct dso *self, struct map *map,
+ const char *vmlinux, symbol_filter_t filter)
{
int err = -1, fd;
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h
index 038f220..6c6eafd 100644
--- a/tools/perf/util/symbol.h
+++ b/tools/perf/util/symbol.h
@@ -166,6 +166,8 @@ void dso__sort_by_name(struct dso *self, enum map_type type);
struct dso *__dsos__findnew(struct list_head *head, const char *name);
int dso__load(struct dso *self, struct map *map, symbol_filter_t filter);
+int dso__load_vmlinux(struct dso *self, struct map *map,
+ const char *vmlinux, symbol_filter_t filter);
int dso__load_vmlinux_path(struct dso *self, struct map *map,
symbol_filter_t filter);
int dso__load_kallsyms(struct dso *self, const char *filename, struct map *map,
--
1.7.3.2
next prev parent reply other threads:[~2010-12-10 13:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 15:00 perf-probe: issue with latest fedora kernel Francis Moreau
2010-12-09 15:35 ` Arnaldo Carvalho de Melo
2010-12-09 16:34 ` Francis Moreau
2010-12-10 3:27 ` Masami Hiramatsu
2010-12-10 7:53 ` Franck Bui-Huu
2010-12-10 8:26 ` Masami Hiramatsu
2010-12-10 13:00 ` Franck Bui-Huu
2010-12-10 13:06 ` Franck Bui-Huu [this message]
2010-12-10 13:07 ` [PATCH 2/2] perf-probe: fail if the kernel image contains no symbol Franck Bui-Huu
2010-12-10 7:30 ` perf-probe: issue with latest fedora kernel Franck Bui-Huu
2010-12-12 14:08 ` Arnaldo Carvalho de Melo
2010-12-12 22:15 ` Franck Bui-Huu
2010-12-13 16:40 ` Arnaldo Carvalho de Melo
2010-12-13 10:02 ` Francis Moreau
2010-12-13 12:58 ` Arnaldo Carvalho de Melo
2010-12-13 13:08 ` Francis Moreau
2010-12-13 14:04 ` Masami Hiramatsu
2010-12-13 14:16 ` Francis Moreau
2010-12-13 19:08 ` Francis Moreau
2010-12-13 14:25 ` Arnaldo Carvalho de Melo
2010-12-13 14:21 ` Arnaldo Carvalho de Melo
2010-12-13 15:11 ` Francis Moreau
2010-12-13 16:40 ` Arnaldo Carvalho de Melo
2010-12-13 19:08 ` Francis Moreau
2010-12-13 19:17 ` Arnaldo Carvalho de Melo
2010-12-13 19:32 ` Francis Moreau
2010-12-15 8:57 ` Masami Hiramatsu
2010-12-15 18:53 ` Arnaldo Carvalho de Melo
2010-12-23 13:59 ` Franck Bui-Huu
2010-12-27 20:50 ` Franck Bui-Huu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hbelydz8.fsf_-_@gmail.com \
--to=vagabon.xyz@gmail.com \
--cc=2nddept-manager@sdl.hitachi.co.jp \
--cc=acme@ghostprotocols.net \
--cc=francis.moro@gmail.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.