From: Markus Armbruster <armbru@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"kvm\@vger.kernel.org" <kvm@vger.kernel.org>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [PATCH 4/4] pci-assign: Remove broken -pcidevice and pci_add host
Date: Wed, 03 Nov 2010 16:22:45 +0100 [thread overview]
Message-ID: <m3hbfya0u2.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <4CD15FB7.5040601@siemens.com> (Jan Kiszka's message of "Wed, 03 Nov 2010 14:12:23 +0100")
Jan Kiszka <jan.kiszka@siemens.com> writes:
> Am 03.11.2010 14:02, Markus Armbruster wrote:
>> Jan Kiszka <jan.kiszka@siemens.com> writes:
>>
>>> These qemu-kvm-only interfaces were broken by b560a9ab9b, but no one
>>> complained loud enough to get them fixed again. As we have properly
>>> working "-device pci-assign"/"device_add" and we won't push this
>>> upstream anyway, there is likely no point in restoring the interface.
>>
>> Agree. Dan wrote re libvirt:
>>
>> As of libvirt >= 0.8.1 & QEMU >= 0.12.x we use switched to using
>> -device for everything. Older libvirt versions had rather broken
>> checking for PCI device topology, so I think it is fine to require
>> libvirt >= 0.8.1 for latest QEMU releases if users want PCI dev
>> assignment. Thus -pcidevice and pci_add can both be killed from our
>> POV.
>>
>> Note that this patch keeps pci_add nic|storage around. Unlikely to make
>> it upstream.
>
> pci_add is already in upstream.
You're right. Can't think straight today.
next prev parent reply other threads:[~2010-11-03 15:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 14:55 [PATCH 0/4] qemu-kvm: Fixes and improvements for device assigment Jan Kiszka
2010-11-02 14:55 ` [PATCH 1/4] pci-assign: Convert iommu property to booleam Jan Kiszka
2010-11-02 14:55 ` [PATCH 2/4] pci-assign: Allow to disable MSI perference for host IRQ Jan Kiszka
2010-11-03 12:54 ` Markus Armbruster
2010-11-02 14:55 ` [PATCH 3/4] pci-assign: Issue warning when running w/o IOMMU Jan Kiszka
2010-11-02 14:55 ` [PATCH 4/4] pci-assign: Remove broken -pcidevice and pci_add host Jan Kiszka
2010-11-03 13:02 ` Markus Armbruster
2010-11-03 13:12 ` Jan Kiszka
2010-11-03 15:22 ` Markus Armbruster [this message]
[not found] ` <4CD119D6.2050602@web.de>
[not found] ` <20101103083321.GE6772@redhat.com>
[not found] ` <4CD120E9.7050306@web.de>
2010-11-03 9:11 ` [PATCH 5/4] pci-assign: Use PCI-2.3-based shared legacy interrupts by default Michael S. Tsirkin
2010-11-03 20:03 ` [PATCH 0/4] qemu-kvm: Fixes and improvements for device assigment Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hbfya0u2.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=berrange@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.