From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] Re: KVM call agenda for July 27 Date: Wed, 28 Jul 2010 15:08:02 +0200 Message-ID: References: <20100726212849.GB2651@x200.localdomain> <4C4E0C05.5030004@codemonkey.ws> <4C4E1A33.7050709@codemonkey.ws> <4C4ED85B.2090807@codemonkey.ws> <4C4EDEF1.9060507@redhat.com> <4C4EFB04.30901@codemonkey.ws> <4C5013C1.3050101@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Chris Wright , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Kevin Wolf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17521 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752421Ab0G1NIG (ORCPT ); Wed, 28 Jul 2010 09:08:06 -0400 In-Reply-To: <4C5013C1.3050101@redhat.com> (Kevin Wolf's message of "Wed, 28 Jul 2010 13:25:53 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Kevin Wolf writes: > Am 28.07.2010 13:22, schrieb Markus Armbruster: >> Anthony Liguori writes: >> >>> On 07/27/2010 10:22 AM, Markus Armbruster wrote: [...] >>>> Raw can't be probed safely, by its very nature. For historical reasons, >>>> we try anyway. I think we should stop doing that, even though that >>>> breaks existing use relying on the misfeature. Announce it now, spit >>>> out scary warnings, kill it for good 1-2 releases later. >>>> >>>> If we're unwilling to do that, then I'd *strongly* prefer doing nothing >>>> over silently messing with the raw writes to sector 0 (so does >>>> Christoph, and he explained why). >>> >>> If we add docs/deprecated-features.txt, schedule removal for at least >>> 1 year in the future, and put a warning in the code that prints >>> whenever raw is probed, I think I could warm up to this. >>> >>> Since libvirt should be insulating users from this today, I think the >>> fall out might not be terrible. >> >> Okay, I'll prepare a patch. > > This kills -hda and friends for raw images. I'm not sure this is a good > idea. Please wait and see my patch.