From: Krzysztof Halasa <khc@pm.waw.pl>
To: Greg KH <gregkh@suse.de>
Cc: Josh Holland <jrh@joshh.co.uk>,
alan@linux.intel.com, andre.goddard@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rar: fixed up rar_driver.{h,c}
Date: Fri, 05 Feb 2010 22:32:50 +0100 [thread overview]
Message-ID: <m3hbpv9xml.fsf@intrepid.localdomain> (raw)
In-Reply-To: <20100205171936.GG14145@suse.de> (Greg KH's message of "Fri, 5 Feb 2010 09:19:36 -0800")
Greg KH <gregkh@suse.de> writes:
> It doesn't matter all that much.
>
> Overall this looks fine, I'll queue it up.
It's an improvement, sure. Doing improvements in smaller, incomplete
steps is right, sure. But it can still be improved further.
--
Krzysztof Halasa
next prev parent reply other threads:[~2010-02-05 21:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 21:23 [PATCH] Staging: rar: fixed up rar_driver.{h,c} Josh Holland
2010-02-05 0:32 ` Krzysztof Halasa
2010-02-05 17:19 ` Greg KH
2010-02-05 21:32 ` Krzysztof Halasa [this message]
2010-02-05 21:58 ` [PATCH 2/2] Staging: rar: More style changes to rar_driver.c Josh Holland
2010-02-17 22:40 ` Greg KH
2010-02-20 11:36 ` Josh Holland
2010-02-24 2:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hbpv9xml.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=alan@linux.intel.com \
--cc=andre.goddard@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jrh@joshh.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.