From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NIUCL-0006g7-4E for qemu-devel@nongnu.org; Wed, 09 Dec 2009 16:35:49 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NIUCG-0006bo-46 for qemu-devel@nongnu.org; Wed, 09 Dec 2009 16:35:48 -0500 Received: from [199.232.76.173] (port=40288 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NIUCG-0006bf-1P for qemu-devel@nongnu.org; Wed, 09 Dec 2009 16:35:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6673) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NIUCF-0001PS-Kd for qemu-devel@nongnu.org; Wed, 09 Dec 2009 16:35:43 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH] Do not abort on qemu_malloc(0) in production builds References: <1260385471-8561-1-git-send-email-aliguori@us.ibm.com> <4B2010A6.5030400@linux.vnet.ibm.com> Date: Wed, 09 Dec 2009 22:35:38 +0100 In-Reply-To: <4B2010A6.5030400@linux.vnet.ibm.com> (Anthony Liguori's message of "Wed, 09 Dec 2009 15:03:34 -0600") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Anthony Liguori , qemu-devel@nongnu.org, Avi Kivity Anthony Liguori writes: > Markus Armbruster wrote: >> This still aborts on qemu_realloc(NULL, 0), even with >> CONFIG_ZERO_MALLOC. Intentional? >> > I guess not. Should it? Seems like a very strange case.. It is a strange case, but I think the point of this commit is not to abort on conditions perceived strange ;) I think it should follow C89 and behave exactly like qemu_malloc(0).