From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ni.piap.pl (ni.piap.pl [195.187.100.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3AE176C7C; Wed, 7 Feb 2024 13:20:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.187.100.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707312021; cv=none; b=Cx5wyv/cSy8tZIVBMfnHxx6dWrCQ+j7PaUuS6VoUjuSkbdRW2qs3OridxlR9tMjD/LaMm/GgpNcCcFNOWCd5ko53qZs4oN1Eyis9eNEbxr1udZrW8MWUfwF67YJskNkdSJPRZMzAjUUdnJyKI8DtHG5JQSr1Yd24RRZMCwn0MJw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707312021; c=relaxed/simple; bh=9XbXN2HqJLMraSRllZfM8SB0u4PwD0X20StBBC/8AV8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Miiy1ge9jVKObNwYE+OOCSZJDUYSlHmQsCmlUdktPkL5EBoTpQwlFRWQL3GqmVeEJ6kHx1WkZxeDCdGF69Waq+PSHJFQdk0qhbq/WsSYeaBSRs42dfvCTPAWzfgoCdIA3iC0orFe4/DZWhVVPKawWQoeexM5KF+4f7WPDFZj3HI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=piap.pl; spf=pass smtp.mailfrom=piap.pl; arc=none smtp.client-ip=195.187.100.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=piap.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=piap.pl Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) by ni.piap.pl (Postfix) with ESMTPS id 2CA3FC3F2A57; Wed, 7 Feb 2024 14:13:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 2CA3FC3F2A57 From: =?utf-8?Q?Krzysztof_Ha=C5=82asa?= To: Laurent Pinchart Cc: Kuninori Morimoto , Hans Verkuil , "Lad, Prabhakar" , =?utf-8?Q?Uwe_Kleine-K=C3=B6nig?= , Alexandre Belloni , Alexandre Torgue , Alexey Brodkin , Alim Akhtar , Andrzej Hajda , Biju Das , Broadcom internal kernel review list , Claudiu Beznea , Daniel Vetter , Dave Stevenson , David Airlie , Eugen Hristev , Florian Fainelli , Helge Deller , Hugues Fruchet , Jacopo Mondi , Jessica Zhang , Krzysztof Kozlowski , Maarten Lankhorst , Mauro Carvalho Chehab , Maxime Coquelin , Maxime Ripard , Neil Armstrong , Nicolas Ferre , Russell King , Sakari Ailus , Sam Ravnborg , Sylwester Nawrocki , Thomas Zimmermann , Tim Harvey , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH 2/4] media: i2c: replace of_graph_get_next_endpoint() In-Reply-To: <20240206134155.GB2827@pendragon.ideasonboard.com> (Laurent Pinchart's message of "Tue, 6 Feb 2024 15:41:55 +0200") References: <87ttmmnvzh.wl-kuninori.morimoto.gx@renesas.com> <87r0hqnvxc.wl-kuninori.morimoto.gx@renesas.com> <20240206134155.GB2827@pendragon.ideasonboard.com> Sender: khalasa@piap.pl Date: Wed, 07 Feb 2024 14:13:05 +0100 Message-ID: Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-KLMS-Rule-ID: 3 X-KLMS-Message-Action: skipped X-KLMS-AntiSpam-Status: not scanned, whitelist X-KLMS-AntiPhishing: not scanned, whitelist X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, not scanned, whitelist Laurent, Laurent Pinchart writes: >> +++ b/drivers/media/i2c/adv7604.c >> @@ -3205,7 +3205,7 @@ static int adv76xx_parse_dt(struct adv76xx_state *= state) >> np =3D state->i2c_clients[ADV76XX_PAGE_IO]->dev.of_node; >> >> /* Parse the endpoint. */ >> - endpoint =3D of_graph_get_next_endpoint(np, NULL); >> + endpoint =3D of_graph_get_endpoint_by_regs(np, 0, -1); > > I think this should be port 1 for the adv7611 and port2 for the adv7612. > The adv7610 may need to use port 1 too, but the bindings likely need to > be updated. To be honest I have no idea about ADV7611 and 7612. The 7610 I have on Tinyrex "mobo" seems to be single port. ADV7611 seems to be mostly a 7610 in a different package (LQFP 64 instead of some BGA 76). The driver simply treats ADV7610 as a 7611. ADV7612 is apparently dual port (only one port can be used at a time) though: [ADV7612] =3D { .type =3D ADV7612, .has_afe =3D false, .max_port =3D ADV76XX_PAD_HDMI_PORT_A, /* B not supported */ .num_dv_ports =3D 1, /* normally 2 */ All related in-tree DTS entries (as of v6.8.0-rc1) seem to be ADV7612. To me it seems all known devices use the first port only. --=20 Krzysztof "Chris" Ha=C5=82asa Sie=C4=87 Badawcza =C5=81ukasiewicz Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP Al. Jerozolimskie 202, 02-486 Warszawa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8EEAC4828D for ; Wed, 7 Feb 2024 13:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1na+4cXszQApfHPh4XRbsGBMdgmPHaEZo+IdzRo8Epc=; b=nuvk9mo22+gkLg N4yHevyYf9W9sPRfrbfPYYNuE/EgMIYdLC3JWgHVyCeYF1aDgn/adomBDgwmWfO77ZUQpmzbCff0Z PcPaaOFKBD5Sc8lqhynrQuXam5tzQ9shJDYPFm3f/vAHZ8myqwpuHCWt6GqTruBwWTDfMcg6KJoZG 3XsxHIMhA1JZqVtbTqg9TeDj6p6bWAWr0jtaTOFSPb+sqhKsSZZy3mZ8krCiGHcnZlN+RSWdzFNgS wARUZp3MhB13/cfZQTspcpiEeUC3OAcJyJUkrE95KmXZugSbsOjGsT+i85ecIGjhKSlGyLHCvn8JP fIemdHk/MP2bxnP6tLLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXhjt-0000000AjFt-370H; Wed, 07 Feb 2024 13:13:21 +0000 Received: from ni.piap.pl ([195.187.100.5]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXhjp-0000000AjDt-349O; Wed, 07 Feb 2024 13:13:20 +0000 Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) by ni.piap.pl (Postfix) with ESMTPS id 2CA3FC3F2A57; Wed, 7 Feb 2024 14:13:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 2CA3FC3F2A57 From: =?utf-8?Q?Krzysztof_Ha=C5=82asa?= To: Laurent Pinchart Subject: Re: [PATCH 2/4] media: i2c: replace of_graph_get_next_endpoint() In-Reply-To: <20240206134155.GB2827@pendragon.ideasonboard.com> (Laurent Pinchart's message of "Tue, 6 Feb 2024 15:41:55 +0200") References: <87ttmmnvzh.wl-kuninori.morimoto.gx@renesas.com> <87r0hqnvxc.wl-kuninori.morimoto.gx@renesas.com> <20240206134155.GB2827@pendragon.ideasonboard.com> Date: Wed, 07 Feb 2024 14:13:05 +0100 Message-ID: MIME-Version: 1.0 X-KLMS-Rule-ID: 3 X-KLMS-Message-Action: skipped X-KLMS-AntiSpam-Status: not scanned, whitelist X-KLMS-AntiPhishing: not scanned, whitelist X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, not scanned, whitelist X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_051317_952878_8ED6DE56 X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Alim Akhtar , Kuninori Morimoto , Alexandre Torgue , dri-devel@lists.freedesktop.org, "Lad, Prabhakar" , Andrzej Hajda , Sylwester Nawrocki , Sakari Ailus , David Airlie , linux-stm32@st-md-mailman.stormreply.com, linux-omap@vger.kernel.org, Florian Fainelli , Dave Stevenson , Hugues Fruchet , Helge Deller , Alexey Brodkin , Russell King , Broadcom internal kernel review list , =?utf-8?Q?Uwe_Kleine-K=C3=B6nig?= , Jessica Zhang , linux-media@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , Tim Harvey , Maarten Lankhorst , Eugen Hristev , Sam Ravnborg , linux-samsung-soc@vger.kernel.org, Maxime Ripard , linux-fbdev@vger.kernel.org, Biju Das , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Neil Armstrong , Thomas Zimmermann , Claudiu Beznea , Krzysztof Kozlowski , Daniel Vetter , Hans Verkuil , linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGF1cmVudCwKCkxhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJk LmNvbT4gd3JpdGVzOgoKPj4gKysrIGIvZHJpdmVycy9tZWRpYS9pMmMvYWR2NzYwNC5jCj4+IEBA IC0zMjA1LDcgKzMyMDUsNyBAQCBzdGF0aWMgaW50IGFkdjc2eHhfcGFyc2VfZHQoc3RydWN0IGFk djc2eHhfc3RhdGUgKnN0YXRlKQo+PiAgICAgICBucCA9IHN0YXRlLT5pMmNfY2xpZW50c1tBRFY3 NlhYX1BBR0VfSU9dLT5kZXYub2Zfbm9kZTsKPj4KPj4gICAgICAgLyogUGFyc2UgdGhlIGVuZHBv aW50LiAqLwo+PiAtICAgICBlbmRwb2ludCA9IG9mX2dyYXBoX2dldF9uZXh0X2VuZHBvaW50KG5w LCBOVUxMKTsKPj4gKyAgICAgZW5kcG9pbnQgPSBvZl9ncmFwaF9nZXRfZW5kcG9pbnRfYnlfcmVn cyhucCwgMCwgLTEpOwo+Cj4gSSB0aGluayB0aGlzIHNob3VsZCBiZSBwb3J0IDEgZm9yIHRoZSBh ZHY3NjExIGFuZCBwb3J0MiBmb3IgdGhlIGFkdjc2MTIuCj4gVGhlIGFkdjc2MTAgbWF5IG5lZWQg dG8gdXNlIHBvcnQgMSB0b28sIGJ1dCB0aGUgYmluZGluZ3MgbGlrZWx5IG5lZWQgdG8KPiBiZSB1 cGRhdGVkLgoKVG8gYmUgaG9uZXN0IEkgaGF2ZSBubyBpZGVhIGFib3V0IEFEVjc2MTEgYW5kIDc2 MTIuClRoZSA3NjEwIEkgaGF2ZSBvbiBUaW55cmV4ICJtb2JvIiBzZWVtcyB0byBiZSBzaW5nbGUg cG9ydC4KCkFEVjc2MTEgc2VlbXMgdG8gYmUgbW9zdGx5IGEgNzYxMCBpbiBhIGRpZmZlcmVudCBw YWNrYWdlIChMUUZQIDY0Cmluc3RlYWQgb2Ygc29tZSBCR0EgNzYpLiBUaGUgZHJpdmVyIHNpbXBs eSB0cmVhdHMgQURWNzYxMCBhcyBhIDc2MTEuCgpBRFY3NjEyIGlzIGFwcGFyZW50bHkgZHVhbCBw b3J0IChvbmx5IG9uZSBwb3J0IGNhbiBiZSB1c2VkIGF0IGEgdGltZSkKdGhvdWdoOgoKW0FEVjc2 MTJdID0gewogICAgICAgIC50eXBlID0gQURWNzYxMiwKICAgICAgICAuaGFzX2FmZSA9IGZhbHNl LAogICAgICAgIC5tYXhfcG9ydCA9IEFEVjc2WFhfUEFEX0hETUlfUE9SVF9BLCAgICAvKiBCIG5v dCBzdXBwb3J0ZWQgKi8KICAgICAgICAubnVtX2R2X3BvcnRzID0gMSwgICAgICAgICAgICAgICAg ICAgICAgLyogbm9ybWFsbHkgMiAqLwoKCkFsbCByZWxhdGVkIGluLXRyZWUgRFRTIGVudHJpZXMg KGFzIG9mIHY2LjguMC1yYzEpIHNlZW0gdG8gYmUgQURWNzYxMi4KClRvIG1lIGl0IHNlZW1zIGFs bCBrbm93biBkZXZpY2VzIHVzZSB0aGUgZmlyc3QgcG9ydCBvbmx5LgotLSAKS3J6eXN6dG9mICJD aHJpcyIgSGHFgmFzYQoKU2llxIcgQmFkYXdjemEgxYF1a2FzaWV3aWN6ClByemVteXPFgm93eSBJ bnN0eXR1dCBBdXRvbWF0eWtpIGkgUG9taWFyw7N3IFBJQVAKQWwuIEplcm96b2xpbXNraWUgMjAy LCAwMi00ODYgV2Fyc3phd2EKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK