From mboxrd@z Thu Jan 1 00:00:00 1970 From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) Date: Mon, 15 Feb 2016 08:07:35 +0100 Subject: [PATCH 2/3] ARM: ixp4xx: avoid warning about ioport_map() macro argument processing In-Reply-To: <1454689262-613421-2-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 5 Feb 2016 17:20:49 +0100") References: <1454689262-613421-1-git-send-email-arnd@arndb.de> <1454689262-613421-2-git-send-email-arnd@arndb.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Arnd Bergmann writes: > We get a harmless compiler warning when building the cs89x0 driver > for ixp4xx: > > drivers/net/ethernet/cirrus/cs89x0.c: In function 'cs89x0_ioport_probe': > drivers/net/ethernet/cirrus/cs89x0.c:1602:28: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] > io_mem = ioport_map(ioport & ~3, NETCARD_IO_EXTENT); > > Simply adding parentheses in the macro avoids the warning > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-ixp4xx/include/mach/io.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Krzysztof Ha?asa -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752186AbcBOHHh (ORCPT ); Mon, 15 Feb 2016 02:07:37 -0500 Received: from ni.piap.pl ([195.187.100.4]:41399 "EHLO ni.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbcBOHHg convert rfc822-to-8bit (ORCPT ); Mon, 15 Feb 2016 02:07:36 -0500 From: khalasa@piap.pl (Krzysztof =?utf-8?Q?Ha=C5=82asa?=) To: Arnd Bergmann Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: ixp4xx: avoid warning about ioport_map() macro argument processing References: <1454689262-613421-1-git-send-email-arnd@arndb.de> <1454689262-613421-2-git-send-email-arnd@arndb.de> Date: Mon, 15 Feb 2016 08:07:35 +0100 In-Reply-To: <1454689262-613421-2-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 5 Feb 2016 17:20:49 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Lua-Profiles: 91323 [Feb 15 2016] X-KLMS-AntiSpam-Version: 5.5.9.33 X-KLMS-AntiSpam-Envelope-From: khalasa@piap.pl X-KLMS-AntiSpam-Rate: 0 X-KLMS-AntiSpam-Status: not_detected X-KLMS-AntiSpam-Method: none X-KLMS-AntiSpam-Moebius-Timestamps: 3962773, 3962804, 3962786 X-KLMS-AntiSpam-Info: LuaCore: 411 411 cee0ce4cf75f1886b5e0f6cefd2eb52abbb231a6, Auth:dkim=none X-KLMS-AntiSpam-Interceptor-Info: scan successful X-KLMS-AntiPhishing: Clean, 2016/02/11 10:58:17 X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2016/02/14 23:24:00 #7167992 X-KLMS-AntiVirus-Status: Clean, skipped Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > We get a harmless compiler warning when building the cs89x0 driver > for ixp4xx: > > drivers/net/ethernet/cirrus/cs89x0.c: In function 'cs89x0_ioport_probe': > drivers/net/ethernet/cirrus/cs89x0.c:1602:28: warning: suggest parentheses around '+' in operand of '&' [-Wparentheses] > io_mem = ioport_map(ioport & ~3, NETCARD_IO_EXTENT); > > Simply adding parentheses in the macro avoids the warning > > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-ixp4xx/include/mach/io.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Krzysztof Hałasa -- Krzysztof Halasa Industrial Research Institute for Automation and Measurements PIAP Al. Jerozolimskie 202, 02-486 Warsaw, Poland