All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Joshua Housh <joshua.housh@calxeda.com>,
	aliguori@us.ibm.com, qemu-devel@nongnu.org,
	Mark Langsdorf <mark.langsdorf@calxeda.com>,
	paul@codesourcery.com
Subject: Re: [Qemu-devel] [PATCH 2/2] qdev: fix NULL deference
Date: Wed, 14 Mar 2012 08:59:50 +0100	[thread overview]
Message-ID: <m3ipi7hatl.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <4F5F981B.3010807@suse.de> ("Andreas Färber"'s message of "Tue, 13 Mar 2012 19:55:23 +0100")

Andreas Färber <afaerber@suse.de> writes:

> Am 13.03.2012 19:32, schrieb Mark Langsdorf:
>> From: Joshua Housh <joshua.housh@calxeda.com>
>> 
>> Make sure a BusInfo exists before trying to dereference it.
>
> What's the use case that breaks?

Valid question.

Every qdev has / used to have a parent bus, and every bus info.  If
that's not true anymore, it would be nice to have the commit message
point to the commit that broke it.

  reply	other threads:[~2012-03-14  8:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 18:32 [Qemu-devel] [PATCH 2/2] qdev: fix NULL deference Mark Langsdorf
2012-03-13 18:55 ` Andreas Färber
2012-03-14  7:59   ` Markus Armbruster [this message]
2012-03-14 14:30     ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ipi7hatl.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=joshua.housh@calxeda.com \
    --cc=mark.langsdorf@calxeda.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.