From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qmirg-00075i-NQ for qemu-devel@nongnu.org; Fri, 29 Jul 2011 04:56:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qmirf-0003NU-8U for qemu-devel@nongnu.org; Fri, 29 Jul 2011 04:56:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qmire-0003NH-Tj for qemu-devel@nongnu.org; Fri, 29 Jul 2011 04:56:15 -0400 From: Markus Armbruster References: <1311179069-27882-1-git-send-email-armbru@redhat.com> <1311179069-27882-50-git-send-email-armbru@redhat.com> <20110726130556.GF2853@lst.de> Date: Fri, 29 Jul 2011 10:56:07 +0200 In-Reply-To: <20110726130556.GF2853@lst.de> (Christoph Hellwig's message of "Tue, 26 Jul 2011 15:05:57 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: kwolf@redhat.com, stefano.stabellini@eu.citrix.com, dbaryshkov@gmail.com, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote: >> Device models should be able to use it without an unclean include of >> block_int.h. > > Hmm. We already do proper read-modify-write cycles for actual data > transfers, so killing the buffer inside SD sounds like the better > idea. qemu_blockalign really should be used only for block-layer internal > allocations. What about the uses in scsi-disk.c and ide/core.c?