From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41294)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QMjdT-0006SF-9k
	for qemu-devel@nongnu.org; Wed, 18 May 2011 12:30:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QMjdR-0000bY-Pu
	for qemu-devel@nongnu.org; Wed, 18 May 2011 12:30:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55964)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1QMjdR-0000bN-HP
	for qemu-devel@nongnu.org; Wed, 18 May 2011 12:30:09 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1305551097-11387-1-git-send-email-armbru@redhat.com>
	<1305551097-11387-4-git-send-email-armbru@redhat.com>
	<4DD3EB1F.9060104@redhat.com>
Date: Wed, 18 May 2011 18:30:03 +0200
In-Reply-To: <4DD3EB1F.9060104@redhat.com> (Kevin Wolf's message of "Wed, 18
	May 2011 17:51:59 +0200")
Message-ID: <m3ipt8nf90.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH v4 3/6] defaults: ide-cd and scsi-cd
	devices suppress default CD-ROM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: lcapitulino@redhat.com, hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com

Kevin Wolf <kwolf@redhat.com> writes:

> Am 16.05.2011 15:04, schrieb Markus Armbruster:
>> ide-hd does *not* suppress the default CD-ROM, unlike legacy
>> ide-drive.
>> 
>> scsi-cd *does* suppress it, unlike legacy scsi-disk.
>> 
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>>  vl.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>> 
>> diff --git a/vl.c b/vl.c
>> index bffba69..e271c0b 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -279,7 +279,9 @@ static struct {
>>      { .driver = "isa-serial",           .flag = &default_serial    },
>>      { .driver = "isa-parallel",         .flag = &default_parallel  },
>>      { .driver = "isa-fdc",              .flag = &default_floppy    },
>> +    { .driver = "ide-cd",               .flag = &default_cdrom     },
>>      { .driver = "ide-drive",            .flag = &default_cdrom     },
>> +    { .driver = "scsi-cd",              .flag = &default_cdrom     },
>>      { .driver = "virtio-serial-pci",    .flag = &default_virtcon   },
>>      { .driver = "virtio-serial-s390",   .flag = &default_virtcon   },
>>      { .driver = "virtio-serial",        .flag = &default_virtcon   },
>
> Wow, I wasn't even aware that we have such magic in relatively new code
> like -device. And that it's only effective for -device, but not -drive.
> And to be honest, I really never wanted to know...

Believe me, I don't like this either.

> Anyway, you can't create an ide-hd on secondary master now because there
> is the default CD-ROM already:
>
> qemu-system-x86_64: -device ide-hd,drive=blubb,unit=0,bus=ide.1: IDE
> unit 0 is in use
> qemu-system-x86_64: -device ide-hd,drive=blubb,unit=0,bus=ide.1: Device
> 'ide-hd' could not be initialized

Meh.  I'll go back to letting any IDE device disable the default CD-ROM.