Re: [PATCH v6] mmc: Add mmc CMD+ACMD passthrough ioctl

[Chris Ball <cjb@laptop.org>]

Hi John, some trivial changes,

On Wed, Apr 13 2011, John Calixto wrote:
> diff --git a/include/linux/mmc/ioctl.h b/include/linux/mmc/ioctl.h
> new file mode 100644
> index 0000000..ad6a871
> --- /dev/null
> +++ b/include/linux/mmc/ioctl.h
> @@ -0,0 +1,46 @@
> +#ifndef _MMC_IOCTL_H
> +#define _MMC_IOCTL_H

Nitpick: LINUX_MMC_IOCTL_H is a little more consistent with the other
headers in include/linux/mmc.

> +struct mmc_ioc_cmd {
> +	/* Implies direction of data.  true = write, false = read */
> +	int write_flag;
> +
> +	/* Application-specific command.  true = precede with CMD55 */
> +	int is_acmd;
> +
> +	__u32 opcode;
> +	__u32 arg;
> +	__u32 response[4];  /* CMD response */
> +	unsigned int flags;
> +	unsigned int blksz;
> +	unsigned int blocks;
> +
> +	/*
> +	 * Sleep at least postsleep_min_us useconds, and at most
> +	 * postsleep_max_us useconds *after* issuing command.  Needed for some
> +	 * read commands for which cards have no other way of indicating
> +	 * they're ready for the next command (i.e. there is no equivalent of a
> +	 * "busy" indicator for read operations).
> +	 */
> +	unsigned int postsleep_min_us;
> +	unsigned int postsleep_max_us;
> +
> +	/*
> +	 * Override driver-computed timeouts.  Note the difference in units!
> +	 */
> +	unsigned int data_timeout_ns;
> +	unsigned int cmd_timeout_ms;
> +
> +	/* DAT buffer */
> +	__u32 data_ptr_size;  /* size of the *pointer* */
> +	__u64 data_ptr;
> +};
> +#define MMC_IOC_CMD _IOWR(MMC_BLOCK_MAJOR, 0, struct mmc_ioc_cmd)

I think we need to register the MMC_BLOCK_MAJOR (== 0xB3 00) prefix in
Documentation/ioctl/ioctl-number.txt.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child