From: Jakub Narebski <jnareb@gmail.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: "Randal L. Schwartz" <merlyn@stonehenge.com>,
Jari Aalto <jari.aalto@cante.net>,
git@vger.kernel.org
Subject: Re: [PATCH RFC 0/5] Patches to avoid reporting conversion changes.
Date: Sat, 17 Apr 2010 15:32:28 -0700 (PDT) [thread overview]
Message-ID: <m3iq7pemnw.fsf@localhost.localdomain> (raw)
In-Reply-To: <n2kfabb9a1e1004171507r3f51d18bq3ff60831370f9b10@mail.gmail.com>
Sverre Rabbelier <srabbelier@gmail.com> writes:
> On Sat, Apr 17, 2010 at 21:34, Randal L. Schwartz <merlyn@stonehenge.com> wrote:
> > Yes, once it's already *in* the program. But I bet you had to *look
> > them up* to add them.
>
> Yes, but once they're there nobody has to look them up. It's moving
> the problem from having to look up what it means on _and_ write, to
> just write.
We use idiomatic C, e.g.
if (!strcmp(option, "warn")) {
not
if (strcmp(option, "warn") == 0) {
We use idiomatic Perl, e.g.
%hash = map { $_ => 1 } @list;
not
use English qw(-no_match_vars);
%hash = map { $ARG => 1 } @list;
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2010-04-17 22:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 16:09 [PATCH RFC 0/5] Patches to avoid reporting conversion changes Henrik Grubbström (Grubba)
2010-04-16 16:09 ` [PATCH RFC 1/5] sha1_file: Added index_blob() Henrik Grubbström (Grubba)
2010-04-16 16:09 ` [PATCH RFC 2/5] cache: Added ce_norm_sha1() and related cache_entry fields Henrik Grubbström (Grubba)
2010-04-16 16:10 ` [PATCH RFC 3/5] cache: Added index extension "NORM" Henrik Grubbström (Grubba)
2010-04-16 16:10 ` [PATCH RFC 4/5] reachable: Made the gc aware of the ce_norm_sha1 Henrik Grubbström (Grubba)
2010-04-16 16:10 ` [PATCH RFC 5/5] cache: Use ce_norm_sha1() Henrik Grubbström (Grubba)
2010-04-20 7:25 ` Junio C Hamano
2010-04-20 15:39 ` Henrik Grubbström
2010-04-20 19:12 ` Junio C Hamano
2010-04-25 11:25 ` Henrik Grubbström
2010-04-16 18:02 ` [PATCH RFC 0/5] Patches to avoid reporting conversion changes Jari Aalto
2010-04-16 18:06 ` Randal L. Schwartz
2010-04-17 19:32 ` Jari Aalto
2010-04-17 19:34 ` Randal L. Schwartz
2010-04-17 22:07 ` Sverre Rabbelier
2010-04-17 22:32 ` Jakub Narebski [this message]
2010-04-17 22:47 ` Sverre Rabbelier
2010-04-17 22:58 ` Randal L. Schwartz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3iq7pemnw.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jari.aalto@cante.net \
--cc=merlyn@stonehenge.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.