From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7sp7-00049T-0l for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:40:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7sp2-00043z-Gk for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:40:00 -0500 Received: from [199.232.76.173] (port=49041 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7sp2-00043f-4D for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:39:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46670) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N7sp0-0004S7-VC for qemu-devel@nongnu.org; Tue, 10 Nov 2009 10:39:55 -0500 From: Juan Quintela In-Reply-To: (Scott Tsai's message of "Tue, 10 Nov 2009 23:14:47 +0800") References: <1257845850-4660-1-git-send-email-scottt.tw@gmail.com> <1257845850-4660-2-git-send-email-scottt.tw@gmail.com> <1257845850-4660-3-git-send-email-scottt.tw@gmail.com> <4AF97D3B.8080601@redhat.com> Date: Tue, 10 Nov 2009 16:39:33 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Tsai Cc: Avi Kivity , qemu-devel@nongnu.org Scott Tsai wrote: >>> + =C2=A0 =C2=A0s->temperature++; >>> >> You're going to overheat very quickly. >> Apart from making the driver work, is this actually useful? > > I wanted the temperature to change with time to give a sense of > "something is happening" ^_^ > > The main user I had in mind was someone new to USB and Linux driver devel= opment > following gregkh's driver tutorial: > http://www.kroah.com/linux/talks/ols_2005_driver_tutorial/ > My thinking was that if the temperature never changes, all the USB > packets generated in the 'read_int_callback" > part of the driver would seem like a waste of effort. Change them in the middle of one interval? once then arrived same limit, 40=C2=B0 or so go back to 20=C2=B0? Later, JUan.