All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "Adam Brewster" <adam@adambrewster.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] Created git-basis and modified git-bundle to accept --stdin.
Date: Tue, 24 Jun 2008 01:09:10 -0700 (PDT)	[thread overview]
Message-ID: <m3iqvzl091.fsf@localhost.localdomain> (raw)
In-Reply-To: <c376da900806231921y2d822been9cd573d509fbf78a@mail.gmail.com>

"Adam Brewster" <adam@adambrewster.com> writes:

> Git-basis is a perl script that remembers bases for use by git-bundle.
> Code from rev-parse was borrowed to allow git-bundle to handle --stdin.

I'd rather you follow git-pack-objects, and use `--revs` for the name
of this option (or even '--not --revs').  The name `--stdin` might
imply that you are providing objects names on stdin of git-bundle.

But perhaps I am worrying over nothing.
 
[...]
> Then you can add the objects in the bundle to the basis, so they won't
> get included in the next pack like this:
> 
>  $ git-basis --update my-basis < my-bundle

Why not use "$(git ls-remote my-bundle)" somewhere in the invocation
creating new bundle instead?
 
> I'm sure that my implementation is crap, but I think this is a useful
> idea.  Anybody agree?  Disagree?

Documentation, please?  Especially that it looks like '--stdin' option
is a bit tricky...

-- 
Jakub Narebski
Poland
ShadeHawk on #git

  reply	other threads:[~2008-06-24  8:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1214273297-8257-1-git-send-email-adambrewster@gmail.com>
     [not found] ` <1214273297-8257-2-git-send-email-adambrewster@gmail.com>
2008-06-24  2:21   ` [PATCH/RFC] Created git-basis and modified git-bundle to accept --stdin Adam Brewster
2008-06-24  8:09     ` Jakub Narebski [this message]
2008-06-24 15:30       ` Adam Brewster
2008-06-24 18:55         ` Jakub Narebski
     [not found]           ` <c376da900806241655q85fc1d9r5bf67096a7930f94@mail.gmail.com>
2008-06-25  0:21             ` Jakub Narebski
2008-06-25  1:14               ` Adam Brewster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3iqvzl091.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=adam@adambrewster.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.