From: Andi Kleen <ak@muc.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Why does x86_64 support a SuSE-specific ioctl?
Date: 05 Oct 2002 17:00:13 +0200 [thread overview]
Message-ID: <m3it0hexs2.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <anm5vf$m6p$1@cesium.transmeta.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
> > -
> > + case TIOCGDEV:
> > + return put_user (kdev_t_to_nr (real_tty->device), (unsigned int*) arg);
>
> This is broken -- you're returning a dev_t as an unsigned int. On
> i386 that means overwriting two bytes of userspace you shouldn't be,
The interface is defined as int, not as dev_t (see the ioctl defines)
I'm not aware of anybody proposing 64bit dev_t for the kernel,
only 32bit dev_t, and the interface provides for that.
-Andi
next prev parent reply other threads:[~2002-10-05 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.NEB.4.44.0210041654570.11119-100000@mimas.fachschaften.tu-muenchen.de.suse.lists.linux.kernel>
2002-10-05 4:35 ` Why does x86_64 support a SuSE-specific ioctl? Andi Kleen
2002-10-05 5:04 ` Jeff Garzik
2002-10-05 5:10 ` Andi Kleen
2002-10-05 13:21 ` Alan Cox
2002-10-05 15:19 ` TIOCGDEV Andi Kleen
2002-10-05 17:00 ` Why does x86_64 support a SuSE-specific ioctl? Miquel van Smoorenburg
2002-10-09 18:03 ` Miquel van Smoorenburg
2002-10-05 7:56 ` H. Peter Anvin
2002-10-05 15:00 ` Andi Kleen [this message]
2002-10-07 17:48 ` Marcelo Tosatti
2002-10-05 13:20 ` Alan Cox
2002-10-05 14:36 ` Andrea Arcangeli
2002-10-04 14:59 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3it0hexs2.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.