All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Wang Shaoyan <stufever@gmail.com>
Cc: miaox@cn.fujitsu.com, linux-btrfs@vger.kernel.org
Subject: Re: can subvolumes be specified as compressed?
Date: Thu, 29 Jul 2010 23:50:58 -0400	[thread overview]
Message-ID: <m3k4odr5jx.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <AANLkTik-0PdjpjNgufGy6n+DawgAkGhv2uuY4BkVmAEV@mail.gmail.com> (Wang Shaoyan's message of "Fri, 30 Jul 2010 11:21:58 +0800")

Hi,

   > I don't know whether this demand, which specified some subvolumes
   > or directories to be compressed, conflict with the design of
   > btrfs's compression feature, may be they want to do this thing
   > well, and everyone will enable the compression feature, rather
   > than throw the decision to user to determine which should
   > compress.

You can't tell whether you can compress data well until you've already
spent CPU compressing it, though.  Right now we have a useful metric
of "if parts of the file fail to compress, bail out on compressing the
rest of the file, both now and in the future"; but it's only a metric.
There are cases this fails on, such as a tar archive that starts out
with JPEGs and continues with large (compressible) text files.

I think the argument that we don't need to offer user control because
we can just do a good job all the time only works if it's actually
true that we can do a good job all the time, and I don't think that's
true here.  So, I still support user control of the per-inode flag.

(I agree about the subvol flags; I think being able to set quotas and
compression per-subvol is on the roadmap and just not done yet.)

-- 
Chris Ball   <cjb@laptop.org>
One Laptop Per Child

      reply	other threads:[~2010-07-30  3:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-29  7:50 can subvolumes be specified as compressed? Wang Shaoyan
2010-07-29  8:21 ` Miao Xie
2010-07-29  8:55   ` Wang Shaoyan
2010-07-29 10:04     ` Miao Xie
2010-07-30  1:29     ` Wang Shaoyan
2010-07-30  2:09       ` Chris Ball
2010-07-30  3:21         ` Wang Shaoyan
2010-07-30  3:50           ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3k4odr5jx.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    --cc=stufever@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.