From: Krzysztof Halasa <khc@pm.waw.pl>
To: u-boot@lists.denx.de
Subject: [U-Boot] Net driver questions
Date: Tue, 03 Nov 2009 00:38:59 +0100 [thread overview]
Message-ID: <m3k4y8ebu4.fsf@intrepid.localdomain> (raw)
In-Reply-To: <200911021753.39366.vapier@gentoo.org> (Mike Frysinger's message of "Mon, 2 Nov 2009 18:53:38 -0400")
Mike Frysinger <vapier@gentoo.org> writes:
>> Let's look... The code does NetSetHandler(TftpHandler).
>> I think NetReceive() calls (*packetHandler)() = TftpHandler and this one
>> may call NetStartAgain().
>
> but this doesnt call recv(), and NetStartAgain() changes the handler, so i
> still dont see recursion with the recv() function. but perhaps your
> definition of recursive is different from mine. recv() does not turn around
> and call recv(), but recv() may turn around and call other driver functions.
I haven't debugged it yet (is there a way to print a backtrace?) but
the first recv() doesn't return from NetReceive().
> the tftp error behavior is to basically discard all pending packets, so in
> practice, it shouldnt be a big deal. it would probably be cleaner though if
> the packet handler returned an integer indicating errors that NetReceive()
> would pass up so that the driver recv knew to stop processing packets right
> away.
I think so. I'll look at it too.
--
Krzysztof Halasa
next prev parent reply other threads:[~2009-11-02 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-01 23:07 [U-Boot] Net driver questions Krzysztof Halasa
2009-11-02 3:32 ` Mike Frysinger
2009-11-02 15:08 ` Krzysztof Halasa
2009-11-02 22:53 ` Mike Frysinger
2009-11-02 23:38 ` Krzysztof Halasa [this message]
2009-11-02 23:54 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3k4y8ebu4.fsf@intrepid.localdomain \
--to=khc@pm.waw.pl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.