From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ni.piap.pl (ni.piap.pl [195.187.100.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4145B30AACB; Tue, 14 Oct 2025 04:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.187.100.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760415899; cv=none; b=QBhApY9oI/0OtFh4ecYFKrvNDe0K/TD1E3IrGeL7Ny4z3BMB1DLJn4YFLHRx3GqzQHS/Ry0sEXhL9612qh1cqP9lRKBzjcNRtnNNZAl61M/u/XzFCENUr5FqJcrh9YyWAJ+Df2bEKIv+EVC3MH92H0IiRduNKy8PW1zBayr7Q9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760415899; c=relaxed/simple; bh=NkEIvHvSMBdftwCCgim71nKU1aLS5jLHCWC9aM4TShQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=nhkqX8rwyt5PdDfbqYP+NMW4Fd6LzbsUDICEwXxzlXa7bqEfDT8Z4vxPzXNEqVhUdpXAKRMVESdC1f9r5TD4zgYU56zQNNUC3XsgxRE6uizRs3hiQRn7yyLjHMvSVhBBoCKHioEsGwPA7q/5/2lI4XsFMZmEbUe8ONfjtUGzRHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=piap.pl; spf=pass smtp.mailfrom=piap.pl; arc=none smtp.client-ip=195.187.100.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=piap.pl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=piap.pl Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) by ni.piap.pl (Postfix) with ESMTPS id 13FA2C3EEAC9; Tue, 14 Oct 2025 06:24:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 13FA2C3EEAC9 From: =?utf-8?Q?Krzysztof_Ha=C5=82asa?= To: Ricardo Ribalda Cc: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?utf-8?Q?S=C3=B6der?= =?utf-8?Q?lund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 05/32] media: ar0521: Use %pe format specifier In-Reply-To: <20251013-ptr_err-v1-5-2c5efbd82952@chromium.org> (Ricardo Ribalda's message of "Mon, 13 Oct 2025 14:14:45 +0000") References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> <20251013-ptr_err-v1-5-2c5efbd82952@chromium.org> Sender: khalasa@piap.pl Date: Tue, 14 Oct 2025 06:24:43 +0200 Message-ID: Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ricardo Ribalda writes: > The %pe format specifier is designed to print error pointers. It prints > a symbolic error name (eg. -EINVAL) and it makes the code simpler by > omitting PTR_ERR() > > This patch fixes this cocci report: > ./i2c/ar0521.c:1113:31-38: WARNING: Consider using %pe to print PTR_ERR() > > Signed-off-by: Ricardo Ribalda Thanks, Acked-by: Krzysztof Ha=C5=82asa > --- a/drivers/media/i2c/ar0521.c > +++ b/drivers/media/i2c/ar0521.c > @@ -1109,8 +1109,8 @@ static int ar0521_probe(struct i2c_client *client) > ar0521_supply_names[cnt]); > > if (IS_ERR(supply)) { > - dev_info(dev, "no %s regulator found: %li\n", > - ar0521_supply_names[cnt], PTR_ERR(supply= )); > + dev_info(dev, "no %s regulator found: %pe\n", > + ar0521_supply_names[cnt], supply); > return PTR_ERR(supply); > } > sensor->supplies[cnt] =3D supply; --=20 Krzysztof "Chris" Ha=C5=82asa Sie=C4=87 Badawcza =C5=81ukasiewicz Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP Al. Jerozolimskie 202, 02-486 Warszawa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F27ECCD184 for ; Tue, 14 Oct 2025 04:25:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=510TCAPMC67Sb4KZ94+mne3SdHynT3XaXrFrGB4hHrU=; b=YwRBwjrnh3NGNG KNe52L8VSwVdeUoEkXr/vrfzhwxUYKyMMM//Gaj1MDsVxxaew6Dq74v+wV/8oOHM7Td6PHPkrpQlG mF4kamEgQwhNIv5pqK1CVciJWyK/04JRlZ8dqcqFPGT+vIm4/0X8wYNjp1PsdEAn/Um8+NBtE7VN3 wQeUNr8MPcvwF8eRoPiRSp683ZAt/S2DtUDMciXDGpaMsNgECkjKMHsgvaW2jdoau3/cMI3hmv1Np oqdwaBjypwBJy0PjPcz1fO9roB9Yu3iv0gz7jgSYj68ZSZtRPos0NwqYZp2U8xZNAZCTP9qnM7ZQj D8fMVx4b/idm1SN4o/sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8Wap-0000000F6a4-03IE; Tue, 14 Oct 2025 04:24:59 +0000 Received: from [195.187.100.5] (helo=ni.piap.pl) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v8Waj-0000000F6Z7-2Si5; Tue, 14 Oct 2025 04:24:56 +0000 Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) by ni.piap.pl (Postfix) with ESMTPS id 13FA2C3EEAC9; Tue, 14 Oct 2025 06:24:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl 13FA2C3EEAC9 From: =?utf-8?Q?Krzysztof_Ha=C5=82asa?= To: Ricardo Ribalda Cc: Linus Walleij , Dmitry Torokhov , Mauro Carvalho Chehab , Hans Verkuil , Sakari Ailus , Tomi Valkeinen , Leon Luo , Kieran Bingham , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?utf-8?Q?S=C3=B6der?= =?utf-8?Q?lund?= , Julien Massot , Jacopo Mondi , Daniel Scally , Dave Stevenson , Benjamin Mugnier , Sylvain Petinot , Yong Zhi , Bingbu Cao , Tianshu Qiu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno , Rui Miguel Silva , Laurent Pinchart , Martin Kepplinger , Purism Kernel Team , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dafna Hirschfeld , Heiko Stuebner , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Yemike Abhilash Chandra , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 05/32] media: ar0521: Use %pe format specifier In-Reply-To: <20251013-ptr_err-v1-5-2c5efbd82952@chromium.org> (Ricardo Ribalda's message of "Mon, 13 Oct 2025 14:14:45 +0000") References: <20251013-ptr_err-v1-0-2c5efbd82952@chromium.org> <20251013-ptr_err-v1-5-2c5efbd82952@chromium.org> Date: Tue, 14 Oct 2025 06:24:43 +0200 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251013_212453_810005_5BFC2BE4 X-CRM114-Status: GOOD ( 10.38 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org UmljYXJkbyBSaWJhbGRhIDxyaWJhbGRhQGNocm9taXVtLm9yZz4gd3JpdGVzOgoKPiBUaGUgJXBl IGZvcm1hdCBzcGVjaWZpZXIgaXMgZGVzaWduZWQgdG8gcHJpbnQgZXJyb3IgcG9pbnRlcnMuIEl0 IHByaW50cwo+IGEgc3ltYm9saWMgZXJyb3IgbmFtZSAoZWcuIC1FSU5WQUwpIGFuZCBpdCBtYWtl cyB0aGUgY29kZSBzaW1wbGVyIGJ5Cj4gb21pdHRpbmcgUFRSX0VSUigpCj4KPiBUaGlzIHBhdGNo IGZpeGVzIHRoaXMgY29jY2kgcmVwb3J0Ogo+IC4vaTJjL2FyMDUyMS5jOjExMTM6MzEtMzg6IFdB Uk5JTkc6IENvbnNpZGVyIHVzaW5nICVwZSB0byBwcmludCBQVFJfRVJSKCkKPgo+IFNpZ25lZC1v ZmYtYnk6IFJpY2FyZG8gUmliYWxkYSA8cmliYWxkYUBjaHJvbWl1bS5vcmc+CgpUaGFua3MsCkFj a2VkLWJ5OiBLcnp5c3p0b2YgSGHFgmFzYSA8a2hhbGFzYUBwaWFwLnBsPgoKPiAtLS0gYS9kcml2 ZXJzL21lZGlhL2kyYy9hcjA1MjEuYwo+ICsrKyBiL2RyaXZlcnMvbWVkaWEvaTJjL2FyMDUyMS5j Cj4gQEAgLTExMDksOCArMTEwOSw4IEBAIHN0YXRpYyBpbnQgYXIwNTIxX3Byb2JlKHN0cnVjdCBp MmNfY2xpZW50ICpjbGllbnQpCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYXIwNTIxX3N1cHBseV9uYW1lc1tjbnRdKTsKPgo+ICAgICAgICAgICAgICAg ICBpZiAoSVNfRVJSKHN1cHBseSkpIHsKPiAtICAgICAgICAgICAgICAgICAgICAgICBkZXZfaW5m byhkZXYsICJubyAlcyByZWd1bGF0b3IgZm91bmQ6ICVsaVxuIiwKPiAtICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBhcjA1MjFfc3VwcGx5X25hbWVzW2NudF0sIFBUUl9FUlIoc3VwcGx5 KSk7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgZGV2X2luZm8oZGV2LCAibm8gJXMgcmVndWxh dG9yIGZvdW5kOiAlcGVcbiIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXIw NTIxX3N1cHBseV9uYW1lc1tjbnRdLCBzdXBwbHkpOwo+ICAgICAgICAgICAgICAgICAgICAgICAg IHJldHVybiBQVFJfRVJSKHN1cHBseSk7Cj4gICAgICAgICAgICAgICAgIH0KPiAgICAgICAgICAg ICAgICAgc2Vuc29yLT5zdXBwbGllc1tjbnRdID0gc3VwcGx5OwoKLS0gCktyenlzenRvZiAiQ2hy aXMiIEhhxYJhc2EKClNpZcSHIEJhZGF3Y3phIMWBdWthc2lld2ljegpQcnplbXlzxYJvd3kgSW5z dHl0dXQgQXV0b21hdHlraSBpIFBvbWlhcsOzdyBQSUFQCkFsLiBKZXJvem9saW1za2llIDIwMiwg MDItNDg2IFdhcnN6YXdhCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LXJvY2tjaGlwCg==