From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55813 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PsX6Y-00027U-Gz
	for qemu-devel@nongnu.org; Thu, 24 Feb 2011 04:03:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PsX6X-0001rX-Ic
	for qemu-devel@nongnu.org; Thu, 24 Feb 2011 04:03:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36782)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PsX6X-0001r2-7s
	for qemu-devel@nongnu.org; Thu, 24 Feb 2011 04:03:21 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <AANLkTimJ48WaEHQ_U5hDCuCTe8N7syx4R9m=0T4kSg=P@mail.gmail.com>
	(Yoshiaki Tamura's message of "Thu, 24 Feb 2011 13:12:01 +0900")
References: <cover.1298492768.git.quintela@redhat.com>
	<e139533b2ab4f13f30ebfe47de68d6bd2989bb5a.1298492768.git.quintela@redhat.com>
	<AANLkTimJ48WaEHQ_U5hDCuCTe8N7syx4R9m=0T4kSg=P@mail.gmail.com>
Date: Thu, 24 Feb 2011 10:01:50 +0100
Message-ID: <m3lj156c1t.fsf@trasno.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 21/28] migration: Make state definitions
	local
Reply-To: quintela@redhat.com
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: qemu-devel@nongnu.org

Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp> wrote:
> 2011/2/24 Juan Quintela <quintela@redhat.com>:
>>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>> =C2=A0migration.c | =C2=A0 =C2=A08 ++++++++
>> =C2=A0migration.h | =C2=A0 =C2=A08 --------
>> =C2=A02 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/migration.c b/migration.c
>> index 493c2d7..697c74f 100644
>> --- a/migration.c
>> +++ b/migration.c
>> @@ -31,6 +31,14 @@
>> =C2=A0 =C2=A0 do { } while (0)
>> =C2=A0#endif
>>
>> +enum migration_state {
>> + =C2=A0  MIG_STATE_ERROR,
>
> Would be better to say:
>
> MIG_STATE_ERROR =3D -1,

I thought about it, but basically it shouldn't matter, no?

Later, Juan.