From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 0/2] Type-safe ioport callbacks Date: Mon, 25 Oct 2010 17:40:39 +0200 Message-ID: References: <1287934469-16624-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61654 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267Ab0JYPko (ORCPT ); Mon, 25 Oct 2010 11:40:44 -0400 In-Reply-To: <1287934469-16624-1-git-send-email-avi@redhat.com> (Avi Kivity's message of "Sun, 24 Oct 2010 17:34:27 +0200") Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity writes: > A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler > complaining because of the type-unsafeness of the ioport callbacks. This > patchset adds a type-safe variant of ioport callbacks and coverts a sample > ioport. Converting the other 300-odd registrations is left as an excercise > to the community. > > Avi Kivity (2): > Type-safe ioport callbacks > piix4 acpi: convert io BAR to type-safe ioport callbacks > > hw/acpi_piix4.c | 30 +++++++++++++++---------- > ioport.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ioport.h | 16 +++++++++++++ > 3 files changed, 98 insertions(+), 12 deletions(-) Related: proper error handling http://www.mail-archive.com/qemu-devel@nongnu.org/msg43710.html I think that could be built nicely on top of this. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39318 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAPAE-0006iI-PD for qemu-devel@nongnu.org; Mon, 25 Oct 2010 11:40:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAPAC-0005RL-PM for qemu-devel@nongnu.org; Mon, 25 Oct 2010 11:40:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAPAC-0005RF-Hh for qemu-devel@nongnu.org; Mon, 25 Oct 2010 11:40:44 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 0/2] Type-safe ioport callbacks References: <1287934469-16624-1-git-send-email-avi@redhat.com> Date: Mon, 25 Oct 2010 17:40:39 +0200 In-Reply-To: <1287934469-16624-1-git-send-email-avi@redhat.com> (Avi Kivity's message of "Sun, 24 Oct 2010 17:34:27 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Avi Kivity writes: > A recent qemu -> qemu-kvm merge broke cpu hotplug without the compiler > complaining because of the type-unsafeness of the ioport callbacks. This > patchset adds a type-safe variant of ioport callbacks and coverts a sample > ioport. Converting the other 300-odd registrations is left as an excercise > to the community. > > Avi Kivity (2): > Type-safe ioport callbacks > piix4 acpi: convert io BAR to type-safe ioport callbacks > > hw/acpi_piix4.c | 30 +++++++++++++++---------- > ioport.c | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ioport.h | 16 +++++++++++++ > 3 files changed, 98 insertions(+), 12 deletions(-) Related: proper error handling http://www.mail-archive.com/qemu-devel@nongnu.org/msg43710.html I think that could be built nicely on top of this.