All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Osterlund <petero2@telia.com>
To: linux-kernel@vger.kernel.org
Cc: Phillip Susi <psusi@cfl.rr.com>,
	bfennema@falcon.csc.calpoly.edu, Christoph Hellwig <hch@lst.de>,
	Al Viro <viro@ftp.linux.org.uk>, Andrew Morton <akpm@osdl.org>
Subject: [RFC][PATCH] UDF filesystem uid fix
Date: 12 Feb 2006 19:17:38 +0100	[thread overview]
Message-ID: <m3lkwg4f25.fsf@telia.com> (raw)

Hi,

I would appreciate if someone with file system knowledge could review
this patch from Phillip Susi.


From: Phillip Susi <psusi@cfl.rr.com>

The UDF filesystem refused to update the file's uid and gid on the
disk if the in memory inode's id matched the values in the uid= and
gid= mount options.  This was causing the owner to change from the
desktop user to root when the volume was ejected and remounted.  I
changed this so that if the inode's id matches the mount option, it
writes a -1 to disk, because when the filesystem reads a -1 from disk,
it uses the mount option for the in memory inode.  This allows you to
use the uid/gid mount options in the way you would expect.
---

 fs/udf/inode.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index 395e582..f892948 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -1337,9 +1337,13 @@ udf_update_inode(struct inode *inode, in
 
 	if (inode->i_uid != UDF_SB(inode->i_sb)->s_uid)
 		fe->uid = cpu_to_le32(inode->i_uid);
+	else
+		fe->uid = cpu_to_le32(-1);
 
 	if (inode->i_gid != UDF_SB(inode->i_sb)->s_gid)
 		fe->gid = cpu_to_le32(inode->i_gid);
+	else
+		fe->gid = cpu_to_le32(-1);
 
 	udfperms =	((inode->i_mode & S_IRWXO)     ) |
 			((inode->i_mode & S_IRWXG) << 2) |

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340

             reply	other threads:[~2006-02-12 18:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-12 18:17 Peter Osterlund [this message]
2006-02-13  9:49 ` [RFC][PATCH] UDF filesystem uid fix Pekka Enberg
2006-02-13 16:51   ` Phillip Susi
2006-02-14  7:28     ` Pekka J Enberg
2006-02-14 11:36       ` Sergey Vlasov
2006-02-14 15:54       ` Phillip Susi
2006-02-15  7:31         ` Pekka Enberg
2006-02-15 15:55           ` Phillip Susi
2006-02-15 17:31             ` Pekka Enberg
2006-02-15 18:48               ` Phillip Susi
2006-02-15 20:28                 ` Pekka Enberg
2006-03-04 23:19                 ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3lkwg4f25.fsf@telia.com \
    --to=petero2@telia.com \
    --cc=akpm@osdl.org \
    --cc=bfennema@falcon.csc.calpoly.edu \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=psusi@cfl.rr.com \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.