All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@muc.de>
To: Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] new device support for forcedeth.c fourth try
Date: Tue, 22 Jun 2004 12:23:55 +0200	[thread overview]
Message-ID: <m3llifevr8.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <29QeD-5kp-11@gated-at.bofh.it> (Carl-Daniel Hailfinger's message of "Tue, 22 Jun 2004 12:00:19 +0200")

Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net> writes:

> Known Bug: You will get a "bad: scheduling while atomic" message because
> of the msleep(500) in PHY reset.
>
> Any suggestions how I can avoid this message? Using mdelay(500) has its
> share of problems too, because it will cause lost time.

Use schedule_work() to push it into a worker thread.
While letting a worker thread sleep for 500ms is also not nice,
it's better than doing it in an interrupt. The best but also
most complicated solution is to set up a timer using add_timer
for this, but this quickly gets you into state machine hell.

-Andi


       reply	other threads:[~2004-06-22 10:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <29ACK-1wm-17@gated-at.bofh.it>
     [not found] ` <29B5I-1QM-3@gated-at.bofh.it>
     [not found]   ` <29QeD-5kp-11@gated-at.bofh.it>
2004-06-22 10:23     ` Andi Kleen [this message]
2004-06-22 13:44       ` [PATCH] new device support for forcedeth.c fourth try Jeff Garzik
2004-06-22 13:54         ` Roland Dreier
2004-06-22 14:32           ` Jeff Garzik
2004-06-21 17:10 [PATCH] new device support for forcedeth.c second try Brian Lazara
2004-06-21 17:36 ` Carl-Daniel Hailfinger
2004-06-22  9:51   ` [PATCH] new device support for forcedeth.c fourth try Carl-Daniel Hailfinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3llifevr8.fsf@averell.firstfloor.org \
    --to=ak@muc.de \
    --cc=c-d.hailfinger.kernel.2004@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.