From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RB6F1-0004kJ-3y for qemu-devel@nongnu.org; Tue, 04 Oct 2011 10:45:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RB6Ez-0002lR-Pp for qemu-devel@nongnu.org; Tue, 04 Oct 2011 10:45:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RB6Ez-0002kJ-I9 for qemu-devel@nongnu.org; Tue, 04 Oct 2011 10:45:05 -0400 From: Juan Quintela In-Reply-To: <4E8B16F8.1050808@codemonkey.ws> (Anthony Liguori's message of "Tue, 04 Oct 2011 09:23:52 -0500") References: <1ecde435c002123860f03fa720f20ff9225fab1b.1316782367.git.quintela@redhat.com> <4E8B16F8.1050808@codemonkey.ws> Date: Tue, 04 Oct 2011 16:44:56 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 05/23] migration: Refactor MigrationState creation Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Anthony Liguori wrote: > On 09/23/2011 07:56 AM, Juan Quintela wrote: >> Signed-off-by: Juan Quintela > > > I think this would fit better if it were migrate_new() or migrate_open(). > > It definitely should be in the form noun_verb and not noun_verb_noun(). > > Regards, You are the native speaker, so I change this one O:-) Later, Juan.