From: Chris Ball <cjb@laptop.org>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression
Date: Thu, 03 Mar 2011 21:28:51 -0500 [thread overview]
Message-ID: <m3mxlbobz0.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <1299205366.4999.3.camel@maxim-laptop> (Maxim Levitsky's message of "Fri, 04 Mar 2011 04:22:46 +0200")
Hi,
On Thu, Mar 03 2011, Maxim Levitsky wrote:
> This patch breaks the CONFIG_MMC_UNSAFE_RESUME, because it sets fake
> non-removeable flag, but the intended use of this option is to assume
> that card is not removed _during_ suspend, and it can still be removed
> during normal use.
> With this commit, card removal isn't detected.
I guess we disagree about the semantics of CONFIG_MMC_UNSAFE_RESUME.
The Kconfig text says:
config MMC_UNSAFE_RESUME
bool "Assume MMC/SD cards are non-removable (DANGEROUS)"
which I interpret as meaning that you should set MMC_UNSAFE_RESUME
*if you're using a card that cannot be removed*. If your card *can* be
removed, then it would be extremely foolish to turn on MMC_UNSAFE_RESUME,
because then if someone removed your removable card during suspend and
modified it in another machine before resuming, you'd get massive
filesystem corruption.
What am I missing?
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2011-03-04 2:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 5:21 [PATCH 0/3] SDIO suspend/resume optimizations Ohad Ben-Cohen
2010-11-28 5:21 ` [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan Ohad Ben-Cohen
2010-12-17 0:51 ` Chris Ball
2010-12-19 22:11 ` Ohad Ben-Cohen
2011-03-04 2:22 ` [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression Maxim Levitsky
2011-03-04 2:28 ` Chris Ball [this message]
2011-03-04 2:52 ` Maxim Levitsky
2011-03-04 5:25 ` Jaehoon Chung
2011-03-04 15:40 ` Maxim Levitsky
2011-03-05 15:03 ` Ohad Ben-Cohen
2011-03-07 19:01 ` Dmitry Shmidt
2011-03-08 16:44 ` Ohad Ben-Cohen
2011-03-08 17:02 ` Maxim Levitsky
2011-03-08 21:10 ` Ohad Ben-Cohen
2010-11-28 5:21 ` [PATCH 2/3] mmc: sdio: don't reinitialize nonremovable powered-resumed cards Ohad Ben-Cohen
2010-11-28 8:42 ` Michał Mirosław
2010-11-28 8:46 ` Ohad Ben-Cohen
2010-11-28 8:58 ` Ohad Ben-Cohen
2010-12-17 0:53 ` Chris Ball
2010-11-28 5:21 ` [PATCH 3/3] mmc: sdio: don't power up cards on system suspend Ohad Ben-Cohen
2010-12-17 1:00 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3mxlbobz0.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.