Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

[Markus Armbruster <armbru@redhat.com>]

Jes Sorensen <Jes.Sorensen@redhat.com> writes:

> On 06/04/10 10:21, Markus Armbruster wrote:
>> Jes.Sorensen@redhat.com writes:
>>> I have tried to be as careful as I can to not break non Linux support,
>>> but as I only have a Linux build environment handy, I would appreciate
>>> it if people with other OSes could check that I didn't break anything
>>> for them. In particular I would like to know if win32 still builds.
>> 
>> I like moving stuff out of vl.c in general.  Your moves of entire
>> functions look like a win to me.  I have doubts about spreading the
>> option switch over three files, though.
>
> The problem is right now there are too many OS specific options, but
> having the #ifdefs plastered all over to enable/disable them accordingly
> is just a nightmare and is prone to leave in inconsistent behavior for
> various OSes. See the set_proc_name() stuff for an example.

I doubt spreading option code over separate files will help consistency.

I suspect the true root of the problem is having (too many) OS-specific
options in the first place.  What about parsing options the same
everywhere, calling out to OS-specific functions to do the actual work?
Let them fail with "can't do this on this OS".