Re: [PATCH ckpt-v15] allocate checkpoint headers with kzalloc

[Nathan Lynch <ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>]

"Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> writes:

> Quoting Nathan Lynch (ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org):
>> In a checkpoint image I noticed a lot of 0x6b (POISON_FREE) bytes
>> corresponding to checkpoint_restart_block -- this indicates that we
>> would write uninitialized kernel memory to the image in cases where
>> slab allocator debugging is not enabled[1].
>> 
>> Use kzalloc in ckpt_hdr_get.
>
> Yikes, yes, that's on par with a recent ecryptfs bug that did the
> same thing.
>
> Have you audited for other such potential privileged data leaks?
> (besides "all sysvipc" which we know about :)

No, haven't audited other things; the strings of 0x6b just caught my eye
and this looked like the obvious fix.  As general rule, I'd say the
checkpoint code should be zeroing any intermediate buffers that could be
written to the image.