All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Osterlund <petero2@telia.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org,
	Arjan van de Ven <arjan@infradead.org>,
	mingo@elte.hu
Subject: [PATCH] pktcdvd: Un-inline some functions
Date: 06 Jan 2006 13:11:00 +0100	[thread overview]
Message-ID: <m3mzi9wo8b.fsf_-_@telia.com> (raw)
In-Reply-To: <1136544226.2940.23.camel@laptopd505.fenrus.org>

Here is a patch to un-inline two functions in the pktcdvd driver.
This makes the compiled code 172 bytes smaller on my system.

Signed-off-by: Peter Osterlund <petero2@telia.com>
---

 drivers/block/pktcdvd.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index b5f67b1..7eb2931 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -247,7 +247,7 @@ static inline struct pkt_rb_node *pkt_rb
 	return rb_entry(n, struct pkt_rb_node, rb_node);
 }
 
-static inline void pkt_rbtree_erase(struct pktcdvd_device *pd, struct pkt_rb_node *node)
+static void pkt_rbtree_erase(struct pktcdvd_device *pd, struct pkt_rb_node *node)
 {
 	rb_erase(&node->rb_node, &pd->bio_queue);
 	mempool_free(node, pd->rb_pool);
@@ -315,7 +315,7 @@ static void pkt_rbtree_insert(struct pkt
 /*
  * Add a bio to a single linked list defined by its head and tail pointers.
  */
-static inline void pkt_add_list_last(struct bio *bio, struct bio **list_head, struct bio **list_tail)
+static void pkt_add_list_last(struct bio *bio, struct bio **list_head, struct bio **list_tail)
 {
 	bio->bi_next = NULL;
 	if (*list_tail) {

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340

  reply	other threads:[~2006-01-06 12:12 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-06 10:37 [patch 1/7] Make __always_inline actually force always inlining Arjan van de Ven
2006-01-06 10:38 ` [patch 2/7] enable unit-at-a-time optimisations for gcc4 Arjan van de Ven
2006-01-06 17:18   ` Jeff Garzik
2006-01-06 18:48     ` Sam Ravnborg
2006-01-06 19:00       ` Arjan van de Ven
2006-01-06 19:02         ` Jeff Garzik
2006-01-06 23:56           ` Sam Ravnborg
2006-01-07  0:05       ` Andi Kleen
2006-01-07  0:20         ` Matt Mackall
2006-01-07  1:11           ` Andi Kleen
2006-01-07  8:47         ` Sam Ravnborg
2006-01-07  9:07   ` Andrew Morton
2006-01-07 10:03     ` Sam Ravnborg
2006-01-07 10:13       ` Andrew Morton
2006-01-07 12:00         ` Sam Ravnborg
2006-01-06 10:39 ` [patch 3/7] mark several functions __always_inline Arjan van de Ven
2006-01-06 10:41 ` [patch 4/7] Mark some key VFS functions as __always_inline Arjan van de Ven
2006-01-06 10:50   ` Al Viro
2006-01-06 10:42 ` [patch 5/7] uninline capable() Arjan van de Ven
2006-01-06 11:18   ` Michael Buesch
2006-01-06 11:22     ` Arjan van de Ven
2006-01-06 11:26       ` Michael Buesch
2006-01-08  5:51         ` [PATCH 1/4] move capable() to capability.h Randy.Dunlap
2006-01-08  7:45           ` Valdis.Kletnieks
2006-01-08 13:48             ` Randy.Dunlap
2006-01-08 18:02             ` Tim Schmielau
2006-01-09  1:55               ` Randy.Dunlap
2006-01-08 18:15           ` Tim Schmielau
2006-01-08 19:03             ` Andrew Morton
2006-01-08 17:19     ` [patch 5/7] uninline capable() Tim Schmielau
2006-01-07  0:28   ` Matt Mackall
2006-01-06 10:43 ` [patch 6/7] Unlinline a bunch of other functions Arjan van de Ven
2006-01-06 12:11   ` Peter Osterlund [this message]
2006-01-06 17:29   ` Jeff Garzik
2006-01-07  6:28   ` Andrew Morton
2006-01-06 10:45 ` [patch 7/7] Make "inline" no longer mandatory for gcc 4.x Arjan van de Ven
2006-01-06 17:31   ` Jeff Garzik
2006-01-06 19:35     ` Arjan van de Ven
2006-01-07  6:33       ` Andrew Morton
2006-01-07  8:34         ` Arjan van de Ven
2006-01-07 19:05   ` Kurt Wall
2006-01-07 19:10     ` Arjan van de Ven
2006-01-07 19:44     ` Arjan van de Ven
2006-01-07 22:13       ` Kurt Wall
2006-01-08  3:16       ` Kurt Wall
2006-01-08  3:56         ` Mitchell Blank Jr
2006-01-08  7:14           ` Kurt Wall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3mzi9wo8b.fsf_-_@telia.com \
    --to=petero2@telia.com \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.