From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49698)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1RPwAS-0003Zw-J0
	for qemu-devel@nongnu.org; Mon, 14 Nov 2011 08:01:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1RPwAR-0007Rs-EH
	for qemu-devel@nongnu.org; Mon, 14 Nov 2011 08:01:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:11085)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1RPwAR-0007Rc-1f
	for qemu-devel@nongnu.org; Mon, 14 Nov 2011 08:01:43 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1321113420-3252-1-git-send-email-aliguori@us.ibm.com> (Anthony
	Liguori's message of "Sat, 12 Nov 2011 09:56:54 -0600")
References: <1321113420-3252-1-git-send-email-aliguori@us.ibm.com>
Date: Mon, 14 Nov 2011 14:00:14 +0100
Message-ID: <m3obweg8pt.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 1/7] migrate: add migration blockers
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Lucas Meneghel Rodrigues <lmr@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Anthony Liguori <aliguori@us.ibm.com> wrote:
> This lets different subsystems register an Error that is thrown whenever
> migration is attempted.  This works nicely because it gracefully supports
> things like hotplug.
>
> Right now, if multiple errors are registered, only one of them is reported.
> I expect that for 1.1, we'll extend query-migrate to return all of the reasons
> why migration is disabled at any given point in time.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  migration.c |   18 ++++++++++++++++++
>  migration.h |   15 +++++++++++++++
>  2 files changed, 33 insertions(+), 0 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 41c3c24..6764d3a 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -398,6 +398,18 @@ static MigrationState *migrate_init(Monitor *mon, int detach, int blk, int inc)
>      return s;
>  }
>  
> +static GSList *migration_blockers;
> +

As said by Kevin, using another list implementation makes no sense on my
book.

Rest of idea ok.