From mboxrd@z Thu Jan  1 00:00:00 1970
From: Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH 1/2] Type-safe ioport callbacks
Date: Mon, 25 Oct 2010 14:54:42 +0200
Message-ID: <m3ocaimnzh.fsf@trasno.mitica>
References: <1287934469-16624-1-git-send-email-avi@redhat.com>
	<1287934469-16624-2-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org,
	kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:18709 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752723Ab0JYMy5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 25 Oct 2010 08:54:57 -0400
In-Reply-To: <1287934469-16624-2-git-send-email-avi@redhat.com> (Avi Kivity's
	message of "Sun, 24 Oct 2010 17:34:28 +0200")
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity <avi@redhat.com> wrote:

> +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> +    IOPort *ioport = opaque;
> +
> +    return ioport->ops->writeb(ioport, addr, data);
> +}
> +
> +static void ioport_writew_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> +    IOPort *ioport = opaque;
> +
> +    return ioport->ops->writew(ioport, addr, data);
> +}
> +
> +static void ioport_writel_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> +    IOPort *ioport = opaque;
> +
> +    return ioport->ops->writel(ioport, addr, data);
> +}

"return" is not needed on this three functions.

Rest of aproach looks good.

Later, Juan.

From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49147 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PAMZd-0005PY-CG
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 08:54:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PAMZc-0006aH-Av
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 08:54:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1PAMZc-0006a7-3Z
	for qemu-devel@nongnu.org; Mon, 25 Oct 2010 08:54:48 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1287934469-16624-2-git-send-email-avi@redhat.com> (Avi Kivity's
	message of "Sun, 24 Oct 2010 17:34:28 +0200")
References: <1287934469-16624-1-git-send-email-avi@redhat.com>
	<1287934469-16624-2-git-send-email-avi@redhat.com>
Date: Mon, 25 Oct 2010 14:54:42 +0200
Message-ID: <m3ocaimnzh.fsf@trasno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 1/2] Type-safe ioport callbacks
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

Avi Kivity <avi@redhat.com> wrote:

> +static void ioport_writeb_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> +    IOPort *ioport = opaque;
> +
> +    return ioport->ops->writeb(ioport, addr, data);
> +}
> +
> +static void ioport_writew_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> +    IOPort *ioport = opaque;
> +
> +    return ioport->ops->writew(ioport, addr, data);
> +}
> +
> +static void ioport_writel_thunk(void *opaque, uint32_t addr, uint32_t data)
> +{
> +    IOPort *ioport = opaque;
> +
> +    return ioport->ops->writel(ioport, addr, data);
> +}

"return" is not needed on this three functions.

Rest of aproach looks good.

Later, Juan.