From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nbzh3-0001Ml-6X
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 12:04:09 -0500
Received: from [199.232.76.173] (port=56885 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nbzh2-0001MM-OI
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 12:04:08 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <armbru@redhat.com>) id 1Nbzh1-0004ag-2T
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 12:04:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1898)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1Nbzh0-0004aY-N1
	for qemu-devel@nongnu.org; Mon, 01 Feb 2010 12:04:06 -0500
Received: from int-mx03.intmail.prod.int.phx2.redhat.com
	(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o11H45og030104
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 1 Feb 2010 12:04:06 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command
References: <1264686180-29845-1-git-send-email-lcapitulino@redhat.com>
	<1264686180-29845-5-git-send-email-lcapitulino@redhat.com>
Date: Mon, 01 Feb 2010 18:04:04 +0100
In-Reply-To: <1264686180-29845-5-git-send-email-lcapitulino@redhat.com> (Luiz
	Capitulino's message of "Thu, 28 Jan 2010 11:42:56 -0200")
Message-ID: <m3ock8nb0b.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> It will be used to switch between "handshake" and "operational"
> modes. Currently it doesn't have any practical effect, as
> mode-oriented support is not enforced yet.
>
> Usage example:
>
> { "execute": "qmp_switch_mode", "arguments": { "mode": "operational" } }
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  monitor.c       |   26 ++++++++++++++++++++++++++
>  qemu-monitor.hx |   15 +++++++++++++++
>  2 files changed, 41 insertions(+), 0 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 3ced51d..f6dd64d 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -704,6 +704,32 @@ static void do_info_qmp_mode(Monitor *mon, QObject **ret_data)
>      *ret_data = qobject_from_jsonf("{ 'mode': %s }", mode);
>  }
>  
> +static void do_qmp_switch_mode(Monitor *mon, const QDict *qdict,
> +                               QObject **ret_data)
> +{
> +    const char *mode;
> +
> +    if (!monitor_ctrl_mode(mon)) {
> +        return;
> +    }

So the command "qmp_switch_mode" is available in the human monitor, but
does nothing?

What about a flag "QMP only?"

[...]