From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NBUz9-0007t2-7S
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 10:01:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NBUz4-0007rl-M0
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 10:01:18 -0500
Received: from [199.232.76.173] (port=46645 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NBUz4-0007rb-D0
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 10:01:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14851)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <armbru@redhat.com>) id 1NBUz2-0005LC-JF
	for qemu-devel@nongnu.org; Fri, 20 Nov 2009 10:01:13 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAKF1BZW005796
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 20 Nov 2009 10:01:11 -0500
From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] isa: configure serial+parallel by index.
References: <1258453721-4530-1-git-send-email-kraxel@redhat.com>
Date: Fri, 20 Nov 2009 16:01:09 +0100
In-Reply-To: <1258453721-4530-1-git-send-email-kraxel@redhat.com> (Gerd
	Hoffmann's message of "Tue, 17 Nov 2009 11:28:41 +0100")
Message-ID: <m3ocmxmea2.fsf@crossbow.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Gerd Hoffmann <kraxel@redhat.com> writes:

> This patch adds a 'index' property to the isa-parallel and isa-serial
> devices.  This can be used to create devices with the default isa irqs
> and ioports by simply specifying the index, i.e.
>
>    -device isa-serial,index=1
>
> instead of
>
>    -device isa-serial,iobase=0x2f8,irq=3
>
> for ttyS1 aka com2.  Likewise for parallel ports.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/parallel.c |    2 +-
>  hw/serial.c   |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/parallel.c b/hw/parallel.c
> index 5ae8348..12693d4 100644
> --- a/hw/parallel.c
> +++ b/hw/parallel.c
> @@ -587,7 +587,7 @@ static ISADeviceInfo parallel_isa_info = {
>      .qdev.size  = sizeof(ISAParallelState),
>      .init       = parallel_isa_initfn,
>      .qdev.props = (Property[]) {
> -        DEFINE_PROP_HEX32("index",  ISAParallelState, index,   -1),
> +        DEFINE_PROP_UINT32("index", ISAParallelState, index,   -1),
>          DEFINE_PROP_HEX32("iobase", ISAParallelState, iobase,  -1),
>          DEFINE_PROP_UINT32("irq",   ISAParallelState, isairq,  7),
>          DEFINE_PROP_CHR("chardev",  ISAParallelState, state.chr),
> diff --git a/hw/serial.c b/hw/serial.c
> index 0063260..e7538ac 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -900,7 +900,7 @@ static ISADeviceInfo serial_isa_info = {
>      .qdev.size  = sizeof(ISASerialState),
>      .init       = serial_isa_initfn,
>      .qdev.props = (Property[]) {
> -        DEFINE_PROP_HEX32("index",  ISASerialState, index,   -1),
> +        DEFINE_PROP_UINT32("index", ISASerialState, index,   -1),
>          DEFINE_PROP_HEX32("iobase", ISASerialState, iobase,  -1),
>          DEFINE_PROP_UINT32("irq",   ISASerialState, isairq,  -1),
>          DEFINE_PROP_CHR("chardev",  ISASerialState, state.chr),

The commit message is bogus.  The patch is a minor fix of commit
e8ee28fb, and the message is a copy of that commit's message.