From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johan Herland <johan@herland.net>,
Robin Rosenberg <robin.rosenberg.lists@dewire.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Add testcase for 'git cvsexportcommit -w $cvsdir ...' with relative $GIT_DIR
Date: Wed, 13 Feb 2008 01:26:57 -0800 (PST) [thread overview]
Message-ID: <m3odalcill.fsf@localhost.localdomain> (raw)
In-Reply-To: <7vabm5s2xs.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
> Except that I'll reorder the patches so that
>
> (1) this test comes first, but with test_expect_failure instead;
>
> (2) then your earlier fix patch, but with a change that changes
> the test_expect_failure to test_expect_success.
>
> Thanks.
>
> Perhaps it would be a good idea to require fix-up patches to
> always come with a test case to prevent future regression.
Perhaps we should add this hint to SubmittingPatches, on top
of your additions? And to t/README?
--
Jakub Narebski
Poland
ShadeHawk on #git
prev parent reply other threads:[~2008-02-13 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 1:28 [PATCH] Fix 'git cvsexportcommit -w $cvsdir ...' when used with relative $GIT_DIR Johan Herland
2008-02-11 20:10 ` Junio C Hamano
2008-02-11 20:58 ` Robin Rosenberg
2008-02-11 23:43 ` Johan Herland
2008-02-12 20:41 ` Robin Rosenberg
2008-02-13 3:11 ` [PATCH] Add testcase for 'git cvsexportcommit -w $cvsdir ...' " Johan Herland
2008-02-13 7:58 ` Junio C Hamano
2008-02-13 9:26 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3odalcill.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=robin.rosenberg.lists@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.