From: Rui Miguel Silva <rmfrfs@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Cc: Adam Ford <aford173@gmail.com>, kernel@pengutronix.de, linux-imx@nxp.com
Subject: Re: [PATCH v1 0/5] media: imx-mipi-csis: Move to subdev active state
Date: Tue, 31 Jan 2023 09:28:18 +0000 [thread overview]
Message-ID: <m3pmavcatp.fsf@gmail.com> (raw)
In-Reply-To: <20230126213437.20796-1-laurent.pinchart@ideasonboard.com>
Hey Laurent,
Thanks for all the cleanups and updates.
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:
> Hello,
>
> This small series moves the imx-mipi-csis driver to use the subdev
> active state. Patches 1/5 to 3/5 are small preparatory cleanups, with
> the main change in 4/5. Patch 5/5 is further cleanup that could have
> been included in 4/5, but that should be easier to review as a separate
> patch.
>
> The series has been tested on the i.MX8MP with the ISI, and IMX296 and
> IMX327 camera sensors.
>
> Laurent Pinchart (5):
> media: imx-mipi-csis: Rename error labels with 'err_' prefix
> media: imx-mipi-csis: Don't take lock in runtime PM handlers
> media: imx-mipi-csis: Pass format explicitly to internal functions
> media: imx-mipi-csis: Use V4L2 subdev active state
> media: imx-mipi-csis: Implement .init_cfg() using .set_fmt()
LGTM, for the all series.
Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Cheers,
Rui
>
> drivers/media/platform/nxp/imx-mipi-csis.c | 249 +++++++++------------
> 1 file changed, 103 insertions(+), 146 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
prev parent reply other threads:[~2023-01-31 9:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 21:34 [PATCH v1 0/5] media: imx-mipi-csis: Move to subdev active state Laurent Pinchart
2023-01-26 21:34 ` [PATCH v1 1/5] media: imx-mipi-csis: Rename error labels with 'err_' prefix Laurent Pinchart
2023-01-27 3:34 ` Adam Ford
2023-01-27 4:30 ` Adam Ford
2023-01-26 21:34 ` [PATCH v1 2/5] media: imx-mipi-csis: Don't take lock in runtime PM handlers Laurent Pinchart
2023-01-26 21:34 ` [PATCH v1 3/5] media: imx-mipi-csis: Pass format explicitly to internal functions Laurent Pinchart
2023-01-26 21:34 ` [PATCH v1 4/5] media: imx-mipi-csis: Use V4L2 subdev active state Laurent Pinchart
2023-01-26 21:34 ` [PATCH v1 5/5] media: imx-mipi-csis: Implement .init_cfg() using .set_fmt() Laurent Pinchart
2023-01-27 1:54 ` [PATCH v1 0/5] media: imx-mipi-csis: Move to subdev active state Adam Ford
2023-01-27 2:29 ` Laurent Pinchart
2023-01-27 3:05 ` Adam Ford
2023-01-31 9:28 ` Rui Miguel Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pmavcatp.fsf@gmail.com \
--to=rmfrfs@gmail.com \
--cc=aford173@gmail.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.