From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qdev-properties: Fix (u)intXX parsers
Date: Wed, 26 May 2010 13:13:31 +0200 [thread overview]
Message-ID: <m3pr0isyp0.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1274869693-22884-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Wed, 26 May 2010 12:28:13 +0200")
Kevin Wolf <kwolf@redhat.com> writes:
> scanf calls must not use PRI constants, they have probably the wrong size and
> corrupt memory. We could replace them by SCN ones, but strtol is simpler than
> scanf here anyway. While at it, also fix the parsers to reject garbage after
> the number ("4096xyz" was accepted before).
Do we have more misuse of PRI with scanf elsewhere? No need to fix them
all in one commit (and thus delay this fix); I just want to make sure
somebody looks.
next prev parent reply other threads:[~2010-05-26 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 10:28 [Qemu-devel] [PATCH] qdev-properties: Fix (u)intXX parsers Kevin Wolf
2010-05-26 10:45 ` Daniel P. Berrange
2010-05-26 10:54 ` Kevin Wolf
2010-05-26 11:13 ` Markus Armbruster [this message]
2010-05-26 11:19 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pr0isyp0.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.